Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return error on template parse error unconditionally #2327

Merged
merged 1 commit into from
Jul 24, 2022
Merged

return error on template parse error unconditionally #2327

merged 1 commit into from
Jul 24, 2022

Conversation

parrasajad
Copy link
Contributor

@parrasajad parrasajad commented Jul 21, 2022 •
edited
Loading

Proposed changes

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@parrasajad parrasajad linked an issue Jul 21, 2022 that may be closed by this pull request
Error handling update with validation #2269
Closed
@parrasajad parrasajad changed the title return on template parse error unconditionally return error on template parse error unconditionally Jul 21, 2022
@ehsandeep ehsandeep merged commit 005b922 into dev Jul 24, 2022
@ehsandeep ehsandeep deleted the validation-err-fix branch July 24, 2022 09:26
@Jaypanchal1401
Copy link

i have also this error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ice3man543 Ice3man543 Ice3man543 approved these changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error handling update with validation
4 participants
@parrasajad @Jaypanchal1401 @ehsandeep @Ice3man543