no need for browser.close() #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Are you saying that even without the headless mode, the browser still spawns? |
Actually, I mean using katana's headless mode with like |
Lemme check. |
dwisiswant0
reviewed
Jul 29, 2024
When the katana process exits, rod will automatically kill the browser process.
dwisiswant0
approved these changes
Jul 30, 2024
|
Hey @zrquan, could you create an issue first before we merge this? |
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the katana process exits, rod will automatically kill the browser process. (go-rod/rod#550 (comment))
Moreover, when using non-headless mode (
-sb), even ifCtrl-cis pressed, the katana will hang onbrowser.close()until the scraping is complete, preventing the process from terminating.Close #978