Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When there is no value on an input, favor HTML's placeholder instead of katana's #957

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

fmuttis
Copy link
Contributor

@fmuttis fmuttis commented Jul 13, 2024

For form extraction, the "value" attribute of an element is used.
When the value is not present, katana uses hardcoded placeholders. E.g. the value "katana".

This patch favors using the "placeholder" attribute of HTML tags if they are present, instead of directly using the hardcoded value.

So for the following form, katana will find "/?something=hello" instead of "/?something=katana":

<form method="GET">
<input type="text" name="something" value="" placeholder="hello">
</form>

@ehsandeep ehsandeep changed the base branch from main to dev July 13, 2024 16:01
@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label Aug 20, 2024
@Mzack9999 Mzack9999 merged commit 091ed54 into projectdiscovery:dev Aug 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants