Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add -store-field-dir flag to store per-host field to custom directory #877

Merged
merged 2 commits into from
Jun 27, 2024
Merged

add -store-field-dir flag to store per-host field to custom directory #877

merged 2 commits into from
Jun 27, 2024

Conversation

dogancanbakir
Copy link
Member

Closes #874

@dogancanbakir dogancanbakir self-assigned this May 6, 2024
@exploit-io
Copy link

Thank You

@Mzack9999 Mzack9999 linked an issue May 8, 2024 that may be closed by this pull request
-store-field Storage Location #874
Closed
Mzack9999
Mzack9999 approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - Unrelated to this PR, just noticing that the output files contain a lot of redundant data (especially the dir one). Shall we create a follow up issue to dedupe them once the scan is completed?

@dogancanbakir dogancanbakir mentioned this pull request May 8, 2024
Closed
ehsandeep
ehsandeep requested changes Jun 27, 2024
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflict

@ehsandeep ehsandeep merged commit 5ae80ae into dev Jun 27, 2024
14 checks passed
@ehsandeep ehsandeep deleted the add_field_store_dir_flag branch June 27, 2024 09:16
@BrewTestBot BrewTestBot mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

-store-field Storage Location
4 participants
@dogancanbakir @exploit-io @ehsandeep @Mzack9999