Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix form extraction: action parsing #1052

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix form extraction: action parsing #1052

merged 1 commit into from
Oct 28, 2024

Conversation

dogancanbakir
Copy link
Member

Closes #1051

@dogancanbakir dogancanbakir self-assigned this Oct 11, 2024
@dogancanbakir dogancanbakir linked an issue Oct 11, 2024 that may be closed by this pull request
'-form-extraction' option: form data ignored (suggested fix) #1051
Closed
Mzack9999
Mzack9999 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - when # is the action the form should be sent via javascript to current document URL (done via document.Url.String())

@ehsandeep ehsandeep merged commit 99269cd into dev Oct 28, 2024
13 checks passed
@ehsandeep ehsandeep deleted the fix_form_extraction branch October 28, 2024 11:15
@BrewTestBot BrewTestBot mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@dogancanbakir dogancanbakir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'-form-extraction' option: form data ignored (suggested fix)
3 participants
@dogancanbakir @ehsandeep @Mzack9999