Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add encrypting secrets spec #113

Merged
merged 1 commit into from
Jan 25, 2025
Merged

docs: add encrypting secrets spec #113

merged 1 commit into from
Jan 25, 2025

Conversation

dwisiswant0
Copy link
Member

dwisiswant0
dwisiswant0 commented Nov 28, 2024
View reviewed changes
tools/nuclei/authenticated-scans.mdx

We are prioritizng support for:
<Note>
This feature is available in Nuclei **vX.Y.Z**.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBD. @ehsandeep

dogancanbakir
dogancanbakir approved these changes Nov 28, 2024
View reviewed changes
tools/nuclei/authenticated-scans.mdx
- **AWS Secrets Manager**
#### Recommended SOPS Configuration

To simplify the encryption process, you can set up a [`.sops.yaml`](https://github.com/projectdiscovery/nuclei/blob/dev/.sops.yaml) file with rules that automatically encrypt specific [fields](/tools/nuclei/authenticated-scans#secret-file-fields) in your files. Here's a recommended configuration:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: update dev with main when this gets merged into main branch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have to wait tho

@ehrishirajsharma
Copy link
Member

merging this, let me know if you want me to hold this PR or revert this.

@ehrishirajsharma ehrishirajsharma merged commit 662f923 into main Jan 25, 2025
1 check passed
@ehrishirajsharma ehrishirajsharma deleted the dwisiswant0/docs/add-encrypting-secrets-spec branch January 25, 2025 21:56
dwisiswant0 added a commit that referenced this pull request Jan 25, 2025
@dwisiswant0
Revert "Merge pull request #113 from projectdiscovery/dwisiswant0/doc…
fff3852 
…s/add-encrypting-secrets-spec"

This reverts commit 662f923, reversing
changes made to f8c02d2.
@dwisiswant0 dwisiswant0 restored the dwisiswant0/docs/add-encrypting-secrets-spec branch January 25, 2025 22:09
@dwisiswant0
Copy link
Member Author

Superseded by #129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogancanbakir dogancanbakir dogancanbakir approved these changes

@ehsandeep ehsandeep Awaiting requested review from ehsandeep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwisiswant0 @ehrishirajsharma @dogancanbakir