Skip to content

Re-add toggle-panorama-view command #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −14
Open

Re-add toggle-panorama-view command #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions src/js/background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,20 +217,6 @@ async function changeActiveGroupBy(offset) {
await toggleVisibleTabs(activeGroup, true);
}

async function triggerCommand(command) {
const options = await loadOptions();

if (options.shortcut[command].disabled) {
// Doesn't execute disabled command
return;
}
if (command === 'activate-next-group') {
await changeActiveGroupBy(1);
} else if (command === 'activate-previous-group') {
await changeActiveGroupBy(-1);
}
}

/** Open the Panorama View tab, or return to the last open tab if Panorama View is currently open */
async function toggleView() {
const extTabs = await browser.tabs.query({ url: browser.extension.getURL('view.html'), currentWindow: true });
Expand All @@ -256,6 +242,22 @@ async function toggleView() {
}
}

async function triggerCommand(command) {
const options = await loadOptions();

if (options.shortcut[command].disabled) {
// Doesn't execute disabled command
return;
}
if (command === 'activate-next-group') {
await changeActiveGroupBy(1);
} else if (command === 'activate-previous-group') {
await changeActiveGroupBy(-1);
} else if (command === 'toggle-panorama-view') {
await toggleView();
}
}

/** Callback function which will be called whenever a tab is opened */
async function tabCreated(tab) {
if (window.backgroundState.openingBackup) {
Expand Down