Allow follower to start with empty initial resource list#6295
Merged
skriss merged 1 commit intoprojectcontour:mainfrom Apr 10, 2024
Merged
Allow follower to start with empty initial resource list#6295skriss merged 1 commit intoprojectcontour:mainfrom
skriss merged 1 commit intoprojectcontour:mainfrom
Conversation
tsaarni
requested review from
skriss and
sunjayBhatia
and removed request for
a team
sunjayBhatia
requested review from
a team,
davinci26 and
rajatvig
and removed request for
a team
Signed-off-by: Tero Saarni <tero.saarni@est.tech>
tsaarni
force-pushed
the
start-with-empty-initial-list
branch
from
497ef40 to
81b2a2d
Compare
tsaarni
added
the
release-note/small
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6295 +/- ##
==========================================
- Coverage 81.56% 81.55% -0.01%
==========================================
Files 133 133
Lines 15801 15805 +4
==========================================
+ Hits 12888 12890 +2
- Misses 2617 2619 +2
Partials 296 296
|
Member
|
LGTM |
|
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
github-actions
bot
added
the
lifecycle/stale
sunjayBhatia
removed
the
lifecycle/stale
SamMHD
pushed a commit
to SamMHD/contour
that referenced
this pull request
Sep 8, 2024
…our#6295) Signed-off-by: Tero Saarni <tero.saarni@est.tech> Signed-off-by: Saman Mahdanian <saman@mahdanian.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a bug that caused follower instance of Contour not reach the ready state when started under following condition:
--watched-namespacesdo not contain any resources.As result, XDS server is not started at all and those Contour instances will not reach ready state.
Note that leader instance still worked correctly even when the conditions were true. This is because leader election triggers "fake" DAG update and therefore the same code path gets executed as if informer delivered some relevant resources that necessitated DAG rebuild - and therefore XDS server start.
The change adds explicit checks to cover the conditions (1) and (2).
Background:
Prior to #5672 we had hardcoded timer that triggered start of XDS server regardless of DAG rebuild status - even if it was not built at all. Starting from 1.27.0 we wait until all relevant resources have been received from the API server and then build the initial DAG. Back then it was not considered that there might not be initial resources and no initial DAG to build at all.
Fixes #6291