Skip to content

internal/provisioner: expose the metrics port for envoy#5101

Merged
skriss merged 7 commits intoprojectcontour:mainfrom
izturn:feat/svc-monitor-port
May 22, 2023
Merged

internal/provisioner: expose the metrics port for envoy#5101
skriss merged 7 commits intoprojectcontour:mainfrom
izturn:feat/svc-monitor-port

Conversation

@izturn
Copy link
Member

@izturn izturn commented Feb 17, 2023 •
edited by skriss
Loading

Expose the default/changed metric port for envoy

Closes #5232.

Signed-off-by: Gang Liu gang.liu@daocloud.io

@izturn
expose metrics port for envoy
6d30970 
Signed-off-by: Gang Liu <gang.liu@daocloud.io>
@izturn
revert makefile
adc70af 
Signed-off-by: Gang Liu <gang.liu@daocloud.io>
@izturn izturn requested a review from a team as a code owner February 17, 2023 08:05
@izturn izturn requested review from skriss and stevesloka and removed request for a team February 17, 2023 08:05
@codecov
Copy link

codecov bot commented Feb 17, 2023 •
edited
Loading

Codecov Report

Merging #5101 (dce8bab) into main (b28dae1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5101      +/-   ##
==========================================
+ Coverage   77.99%   78.00%   +0.01%     
==========================================
  Files         138      138              
  Lines       18269    18285      +16     
==========================================
+ Hits        14248    14264      +16     
  Misses       3746     3746              
  Partials      275      275
Impacted Files Coverage Δ
internal/provisioner/objects/object.go 82.50% <ø> (ø)
...nternal/provisioner/objects/dataplane/dataplane.go 85.88% <100.00%> (+0.55%) ⬆️

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 4, 2023
@izturn
Copy link
Member Author

izturn commented Mar 11, 2023

ping @skriss @sunjayBhatia

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 11, 2023
@github-actions
Copy link

github-actions bot commented Mar 25, 2023

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 25, 2023
@izturn
Copy link
Member Author

izturn commented Mar 29, 2023

ping @sunjayBhatia @skriss

This was referenced Mar 29, 2023
Closed
Closed
@Jean-Daniel
Copy link
Contributor

Jean-Daniel commented Mar 29, 2023 •
edited
Loading

Is the usage of --stats-port flag required ?
The last time I tried, I saw that contour was directly using the value from its contourConfiguration to configure the envoy metric listener (it is already properly configure on Contour 1.24).

So I don't think there is a need to add an extra flag to the contour deployment.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 30, 2023
skriss
skriss reviewed Apr 4, 2023
View reviewed changes
skriss
skriss reviewed Apr 4, 2023
View reviewed changes
@izturn
Copy link
Member Author

izturn commented Apr 10, 2023

ok, i will upgrade it

@izturn
merge & fix conflict & refactor
2beef7e 
Signed-off-by: Gang Liu <gang.liu@daocloud.io>
@izturn izturn requested a review from skriss April 10, 2023 03:35
@github-actions
Copy link

github-actions bot commented Apr 25, 2023

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 14d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 25, 2023
@izturn
Copy link
Member Author

izturn commented May 6, 2023

gentle ping @skriss @sunjayBhatia

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 7, 2023
skriss
skriss requested changes May 8, 2023
View reviewed changes
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits, but otherwise looks reasonable 👍

@skriss skriss added the release-note/small A small change that needs one line of explanation in the release notes. label May 8, 2023
@skriss skriss added this to the 1.26.0 milestone May 8, 2023
@skriss
Copy link
Member

skriss commented May 8, 2023

Please add a changelog file as well.

@izturn izturn requested a review from skriss May 18, 2023 06:57
skriss
skriss requested changes May 18, 2023
View reviewed changes
@izturn izturn requested a review from skriss May 20, 2023 09:13
skriss
skriss approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @izturn

@skriss skriss merged commit eac433e into projectcontour:main May 22, 2023
@github-actions github-actions bot mentioned this pull request Feb 27, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skriss skriss skriss approved these changes

@stevesloka stevesloka Awaiting requested review from stevesloka stevesloka is a code owner automatically assigned from projectcontour/maintainers

Assignees

No one assigned

Labels

release-note/small A small change that needs one line of explanation in the release notes.

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

[provisioner] envoy should expose the metrics port.

3 participants

@izturn @Jean-Daniel @skriss