Design: ExtAuth HTTP support#4995
Merged
sunjayBhatia merged 1 commit intoprojectcontour:mainfrom Feb 9, 2023
Merged
Conversation
clayton-gonsalves
requested review from
skriss and
sunjayBhatia
and removed request for
a team
clayton-gonsalves
force-pushed
the
add-design-for-ext-auth-http-support
branch
2 times, most recently
from
15c1e9b to
fedc1c8
Compare
davinci26
approved these changes
Jan 23, 2023
Contributor
davinci26
left a comment
davinci26
left a comment
There was a problem hiding this comment.
Some minor nits. My opinion doesn't hold much weight in this project but imho this is a great feature for single tenant clusters that want a uniform behaviour enforced by a single infra team.
sunjayBhatia
added
the
release-note/none-required
clayton-gonsalves
force-pushed
the
add-design-for-ext-auth-http-support
branch
from
aab3cb9 to
b2080d7
Compare
skriss
reviewed
Jan 30, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4995 +/- ##
==========================================
+ Coverage 77.49% 77.60% +0.11%
==========================================
Files 138 138
Lines 16904 17131 +227
==========================================
+ Hits 13099 13294 +195
- Misses 3550 3580 +30
- Partials 255 257 +2
|
clayton-gonsalves
force-pushed
the
add-design-for-ext-auth-http-support
branch
from
8e0f29c to
fefd98a
Compare
sunjayBhatia
reviewed
Feb 6, 2023
Member
sunjayBhatia
left a comment
sunjayBhatia
left a comment
There was a problem hiding this comment.
I think this LGTM, we can work out some more fine details as needed in PR review of the actual implementation
Just needs a main merge (just to get CI happy) and should be good to go
clayton-gonsalves
force-pushed
the
add-design-for-ext-auth-http-support
branch
from
fefd98a to
ecbcd8c
Compare
skriss
approved these changes
Feb 7, 2023
Member
skriss
left a comment
skriss
left a comment
There was a problem hiding this comment.
👍 to moving ahead with this. I did have one final question but it doesn't need to block starting to make progress here. Thanks for the work here @clayton-gonsalves!
Design proposal to address projectcontour#4954 Signed-off-by: clayton-gonsalves <clayton.gonsalves@reddit.com>
clayton-gonsalves
force-pushed
the
add-design-for-ext-auth-http-support
branch
from
ecbcd8c to
d11a0cd
Compare
skriss
approved these changes
Feb 9, 2023
sunjayBhatia
approved these changes
Feb 9, 2023
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
Signed-off-by: clayton-gonsalves <clayton.gonsalves@reddit.com> Signed-off-by: yy <yang.yang@daocloud.io>
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
Signed-off-by: clayton-gonsalves <clayton.gonsalves@reddit.com> Signed-off-by: yy <yang.yang@daocloud.io>
vmw-yingy
pushed a commit
to vmw-yingy/contour
that referenced
this pull request
Feb 28, 2023
Signed-off-by: clayton-gonsalves <clayton.gonsalves@reddit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design proposal to address #4954
There is a WIP draft PR with some of the intended code changes.
Signed-off-by: Clayton Gonsalves claytonivorgonsalves@gmail.com