cmd/contour: add EnableXRateLimitHeaders config file setting#3457
Merged
skriss merged 1 commit intoprojectcontour:mainfrom Mar 16, 2021
Merged
cmd/contour: add EnableXRateLimitHeaders config file setting#3457skriss merged 1 commit intoprojectcontour:mainfrom
skriss merged 1 commit intoprojectcontour:mainfrom
Conversation
skriss
requested review from
danehans and
youngnick
and removed request for
a team
Member
Author
|
I assumed that folks agreed with #3431 (comment), but I'd still appreciate input one way or another on that. Easy enough to change things if we want to switch to a non-boolean config option. |
Codecov Report
@@ Coverage Diff @@
## main #3457 +/- ##
==========================================
+ Coverage 75.15% 75.21% +0.05%
==========================================
Files 98 98
Lines 6586 6592 +6
==========================================
+ Hits 4950 4958 +8
+ Misses 1523 1521 -2
Partials 113 113
|
sunjayBhatia
approved these changes
Mar 8, 2021
Member
sunjayBhatia
left a comment
sunjayBhatia
left a comment
There was a problem hiding this comment.
LGTM assuming the boolean option is cool with everyone
stevesloka
added
the
release-note
stevesloka
approved these changes
Mar 12, 2021
stevesloka
approved these changes
Mar 12, 2021
Member
Author
|
sounds like using the bool works for everyone, but I'll leave this open for one more day in case @youngnick or @xaleeks have further input. |
Adds the EnableXRateLimitHeaders field to the config file's RateLimitService block. When set to true, adds the X-RateLimit headers to responses that required checking the RLS. Closes projectcontour#3431. Signed-off-by: Steve Kriss <krisss@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the EnableXRateLimitHeaders field to the config file's
RateLimitService block. When set to true, adds the X-RateLimit
headers to responses that required checking the RLS.
Closes #3431.
Signed-off-by: Steve Kriss krisss@vmware.com