Update metrics examples for Envoy v1.10#1085
Merged
stevesloka merged 1 commit intoprojectcontour:masterfrom May 15, 2019
Merged
Update metrics examples for Envoy v1.10#1085stevesloka merged 1 commit intoprojectcontour:masterfrom
stevesloka merged 1 commit intoprojectcontour:masterfrom
Conversation
Contributor
Author
|
I will try to test the host-split setup on a test cluster (have test others) soon. If someone wants to help testing it, please feel free to do it :) |
This was referenced May 13, 2019
Closed
rata
force-pushed
the
rata/update-metrics-envoy-1.10
branch
from
058cf8d to
59a5317
Compare
Member
|
Hey @rata thanks for this! I want to double check the histograms quickly before merging to validate they indeed work the way they are supposed to in v1.10. |
davecheney
reviewed
May 14, 2019
Contributor
Author
|
@stevesloka please, go ahead. I've tried it and I'm using contour with envoy 1.10, and I see all the histogram metrics in a test and production environment for a few weeks already, if it helps :) And thank you :) |
Contributor
|
summoning @youngnick for visibility. |
stevesloka
approved these changes
May 15, 2019
Member
stevesloka
left a comment
stevesloka
left a comment
There was a problem hiding this comment.
/lgtm
Thanks for this @rata!! If you could just rebase we'll get this merged. =)
Since the recent upgrade to envoy 1.10 there is no need to use the statsd sink, as envoy exports those metrics by default to prometheus now. This was added on envoy PR: envoyproxy/envoy#5601 that is included in 1.10. This commits just removes the statsd references and updates the doc. With these changes, the statsd-enable contour flag can probably be removed on a future patch, will create an issue for that. Fixes: projectcontour#1035 Signed-off-by: Rodrigo Campos <rodrigo@kinvolk.io>
rata
force-pushed
the
rata/update-metrics-envoy-1.10
branch
from
edd4500 to
ac6e484
Compare
Contributor
Author
|
@stevesloka thank you! I just rebased :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the recent upgrade to envoy 1.10 there is no need to use the
statsd sink, as envoy exports those metrics by default to prometheus
now.
This was added on envoy PR:
envoyproxy/envoy#5601 that is included in 1.10.
This commits just removes the statsd references and updates the doc.
With these changes, the statsd-enable contour flag can probably be
removed on a future patch, will create an issue for that.
Fixes: #1035
Signed-off-by: Rodrigo Campos rodrigo@kinvolk.io