refactor: drop django-mptt in favour of django-tree-queries #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czosel
reviewed
Jun 5, 2024
|
Once the conflicts are resolved we can merge 👍 |
winged
force-pushed
the
drop_mptt
branch
5 times, most recently
from
b742f34
to
949f4ab
Compare
Django-Tree-Queries works with recursive CTEs (common table expressions) to deal with hierarchical relationships, generally achieving the same result, but without the `right`, `left` and `tree_id` fields. Django-MPTT has been unmaintained for several years, and we're suspecting some subtle bugs in it that we can't really reproduce or verify right now. Anyway it's a good time to get rid of it. Note: Some old migrations needed to be changed, as we cannot refer to MPTT fields anymore. They were essentially regular foreign keys however, so this won't break the database. BREAKING! This breaks if Emeis is used as a Django app directly, and depends on any of the MPTT API / features.
czosel
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django-Tree-Queries works with recursive CTEs (common table expressions) to deal with hierarchical relationships, generally achieving the same result, but without the
right,leftandtree_idfields.Django-MPTT has been unmaintained for several years, and we're suspecting some subtle bugs in it that we can't really reproduce or verify right now. Anyway it's a good time to get rid of it.
BREAKING! This breaks if Emeis is used as a Django app directly, and depends on any of the MPTT API / features.