Initial work to opensource guardian #9849
Draft
+2,768
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
Brian-McM
force-pushed
the
bm-add-guardian-to-oss
branch
6 times, most recently
from
a84cc49 to
8581bb4
Compare
This commit adds guardian, a component that can connect to calico cloud. This facilitates open source clusters connecting to calico free tier.
Brian-McM
force-pushed
the
bm-add-guardian-to-oss
branch
from
8581bb4 to
09d1626
Compare
asincu
reviewed
Feb 18, 2025
| tlsCfg := tls.NewTLSConfig() | ||
|
|
||
| if tgt.AllowInsecureTLS { | ||
| tlsCfg.InsecureSkipVerify = true |
There was a problem hiding this comment.
Should we drop this setting ?
| ClientCertPath string `json:"clientCertPath"` | ||
| ClientKeyPath string `json:"clientKeyPath"` | ||
|
|
||
| Unauthenticated bool `json:"unauthenticated,omitempty"` |
| ListenAndServeManagementCluster(ctx context.Context) error | ||
| } | ||
|
|
||
| // Client is the voltron client. It is used by Guardian to establish a secure tunnel connection to the Voltron server and |
There was a problem hiding this comment.
I think this is called server now and it is not public.
| http: new(http.Server), | ||
|
|
||
| tunnelAddr: addr, | ||
| tunnelServerName: strings.Split(addr, ":")[0], |
There was a problem hiding this comment.
What if we have an IPV6 address ?
|
|
||
| var dialer tunnel.SessionDialer | ||
| if srv.tunnelCert == nil { | ||
| log.Warnf("No tunnel creds, using unsecured tunnel") |
There was a problem hiding this comment.
We should probably drop support for unsecure tunnel
| ) | ||
|
|
||
| const ( | ||
| tunnelNetwork = "voltron-tunnel" |
There was a problem hiding this comment.
I wonder if there is any benefits to configure this at start up instead of hard-coding it. In case we want to change it, it would be better to not hard-coded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.