Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure existing CNI config file has correct permissions #9656

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kashifest
Copy link

@kashifest kashifest commented Dec 31, 2024

Description

Related issues/PRs

fixes #9619

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Ensure existing CNI config file has correct permissions on upgrade

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@kashifest kashifest requested a review from a team as a code owner December 31, 2024 09:05
@marvin-tigera marvin-tigera added this to the Calico v3.30.0 milestone Dec 31, 2024
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Dec 31, 2024
@CLAassistant
Copy link

CLAassistant commented Dec 31, 2024

CLA assistant check
All committers have signed the CLA.

@kashifest kashifest force-pushed the kashif/fix-CNI-file-permission-on-existing-files branch from dcc70c3 to 559f991 Compare December 31, 2024 17:36
Copy link
Member

@caseydavenport caseydavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit but otherwise LGTM

@kashifest kashifest force-pushed the kashif/fix-CNI-file-permission-on-existing-files branch from 559f991 to 3bebbba Compare December 31, 2024 17:51
@caseydavenport
Copy link
Member

/sem-approve

@caseydavenport caseydavenport added merge-when-ready docs-not-required Docs not required for this change labels Dec 31, 2024
@marvin-tigera marvin-tigera removed the docs-pr-required Change is not yet documented label Dec 31, 2024
@kashifest
Copy link
Author

@caseydavenport @marvin-tigera any clue/suggestion why the test failed ?

@kashifest
Copy link
Author

/retest

@kashifest
Copy link
Author

If I understand the logs from the test correctly the failure is not related to this PR and seems like a flake.

* Pulling artifacts:00:01
$ /usr/local/bin/artifact pull workflow test-results/33fcc9c6-07f6-4ab1-bc5b-fbe8d94494ae -d /tmp/test-results133554972600:01
* Pulling artifacts failed: exit status 100:01
[Jan 10 23:00:45.384] Error pulling artifact: failed to generate signed URLs - hub returned 404 status code00:01
[Jan 10 23:00:45.384] Please check if the artifact you are trying to pull exists.00:01
Error: exit status 1 

Can someone with permission retrigger the test please?

@lwr20
Copy link
Member

lwr20 commented Jan 13, 2025

/sem-approve

@lwr20
Copy link
Member

lwr20 commented Jan 13, 2025

This is failing pre-flight checks - looks like its failing due to the year in the copyright notices. This might have been fixed in master - #9666 - hopefully you just need to rebase?

@kashifest kashifest force-pushed the kashif/fix-CNI-file-permission-on-existing-files branch from 3bebbba to a90a147 Compare January 13, 2025 10:25
@marvin-tigera
Copy link
Contributor

Removing "merge-when-ready" label due to new commits

@kashifest
Copy link
Author

kashifest commented Jan 13, 2025

This is failing pre-flight checks - looks like its failing due to the year in the copyright notices. This might have been fixed in master - #9666 - hopefully you just need to rebase?

Rebased. Thanks

@kashifest
Copy link
Author

now the test is not getting triggered 😞

@lwr20
Copy link
Member

lwr20 commented Jan 14, 2025

Going to try closing and reopening to see if we can persuade CI to run.

@lwr20 lwr20 closed this Jan 14, 2025
@lwr20 lwr20 reopened this Jan 14, 2025
@marvin-tigera marvin-tigera removed the release-note-required Change has user-facing impact (no matter how small) label Jan 14, 2025
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented and removed docs-not-required Docs not required for this change labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-pr-required Change is not yet documented release-note-required Change has user-facing impact (no matter how small)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CNI File permission on existing files
5 participants