-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure existing CNI config file has correct permissions #9656
base: master
Are you sure you want to change the base?
Ensure existing CNI config file has correct permissions #9656
Conversation
dcc70c3
to
559f991
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit but otherwise LGTM
559f991
to
3bebbba
Compare
/sem-approve |
@caseydavenport @marvin-tigera any clue/suggestion why the test failed ? |
/retest |
If I understand the logs from the test correctly the failure is not related to this PR and seems like a flake.
Can someone with permission retrigger the test please? |
/sem-approve |
This is failing pre-flight checks - looks like its failing due to the year in the copyright notices. This might have been fixed in master - #9666 - hopefully you just need to rebase? |
Signed-off-by: Kashif Khan <[email protected]>
3bebbba
to
a90a147
Compare
Removing "merge-when-ready" label due to new commits |
Rebased. Thanks |
now the test is not getting triggered 😞 |
Going to try closing and reopening to see if we can persuade CI to run. |
Description
Related issues/PRs
fixes #9619
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*
label.docs-pr-required
: This change requires a change to the documentation that has not been completed yet.docs-completed
: This change has all necessary documentation completed.docs-not-required
: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*
label.release-note-required
: This PR has user-facing changes. Most PRs should have this label.release-note-not-required
: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate
: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr
: This PR is related to install and requires a corresponding change to the operator.