Upgrade hcsshim to 0.12.8 and update logic for stale endpoint for hyperv #9505
+67
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
coutinhop
added
docs-not-required
ritikaguptams
force-pushed
the
hypervSupport
branch
from
1e2c95e to
e81f324
Compare
ritikaguptams
changed the title
|
/sem-approve |
ritikaguptams
force-pushed
the
hypervSupport
branch
from
e81f324 to
96d5ec1
Compare
|
/sem-approve |
ritikaguptams
force-pushed
the
hypervSupport
branch
from
96d5ec1 to
8ac485e
Compare
hjiawei
reviewed
Jan 14, 2025
| cali1Rule = netlink.Rule{ | ||
| Priority: 100, | ||
| Family: unix.AF_INET, | ||
| Src: mustParseCIDR("10.0.0.1/32"), | ||
| Mark: 0x100, | ||
| Mask: 0x100, | ||
| Mask: &mask1, |
There was a problem hiding this comment.
nit. Non-blocking. We can probably use the k8s ptr helper utility. This line can be ptr.To[uint32](0x100).
hjiawei
reviewed
Jan 14, 2025
| @@ -75,7 +75,7 @@ require ( | |||
| github.com/tchap/go-patricia/v2 v2.3.1 | |||
| github.com/termie/go-shutil v0.0.0-20140729215957-bcacb06fecae | |||
| github.com/urfave/cli/v2 v2.27.5 | |||
| github.com/vishvananda/netlink v1.2.1-beta.2.0.20240703200800-b54f85093f4a | |||
| github.com/vishvananda/netlink v1.3.0 | |||
There was a problem hiding this comment.
There is a breaking change in vishvananda/netlink that Mask is changed from int to *uint32 (Mark from int to uint32). We may need to validate that in production code to avoid any nil pointer dereference or usage.
…erv isolation Signed-off-by: ritikaguptams <[email protected]> Upgrading hcshim Signed-off-by: ritikaguptams <[email protected]> Fixing tests to update netlink to 1.30 Signed-off-by: ritikaguptams <[email protected]>
ritikaguptams
force-pushed
the
hypervSupport
branch
from
8ac485e to
4d6bd7b
Compare
|
/sem-approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Complete information of this PR is documented here.
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.