Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerized dev #1474

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft

Dockerized dev #1474

wants to merge 25 commits into from

Conversation

dl-maura
Copy link
Contributor

This is building off of the Blacklight local docker development system, giving you an option to run a local dev using docker.

Fulfills ticket 1443.

To test, follow the readme directions and confirm it works! Recommend squash merging I had typos I had to fix so a lot of commit messages.

Copy link
Contributor

@gwiedeman gwiedeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, and is working great for me. I just made two very minor suggestions to get the old README to jive with the updates.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Contributor

@marlo-longley marlo-longley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dl-maura nice work! This works locally for me.

I would advocate for cleaning up the multiple commits in this PR before a final review/merge. Also not sure where things are at with the testing -- let me know if you want a second pair of eyes.

@seanaery
Copy link
Contributor

Hi @dl-maura -- a fresh pull of this branch and I'm back to getting SQLite errors upon a docker-compose up again (on an M1 Mac). It was definitely working Friday when I tried (with export DOCKER_DEFAULT_PLATFORM=linux/amd64) , so not sure what's different now.

@dl-maura dl-maura changed the title Dockerized dev Dockerized dev (In progress, don't merge) Dec 14, 2023
@dl-maura
Copy link
Contributor Author

Current state: this 'works' but some of the selenium tests are failing, I think because of ports needing to be exposed (the code that is failing is not affected at all by the work here). I am going to speak to a colleague who knows more than I do about Rails tests to see if I can get it worked out next week.

@dl-maura dl-maura marked this pull request as draft December 15, 2023 15:02
@dl-maura dl-maura changed the title Dockerized dev (In progress, don't merge) Dockerized dev Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants