[docker-1.12-2] Signature verification on pull #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@mrunalp PTAL |
runcom
force-pushed
the
verify-sigs-on-pull-1.12.2
branch
2 times, most recently
from
a876fd3 to
93e4836
Compare
Signed-off-by: Antonio Murdaca <[email protected]>
runcom
force-pushed
the
verify-sigs-on-pull-1.12.2
branch
from
93e4836 to
19c750e
Compare
rhatdan
reviewed
Oct 25, 2016
distribution/pull_v2_unix.go
Outdated
Member
There was a problem hiding this comment.
Would putting these into a separate file make maintaining this patch easier?
Member
There was a problem hiding this comment.
Again, should this be in a separate file?
policy.json
Outdated
Member
|
I am going to merge, my review was from a while ago, but I never completed it. Perhaps as we go foward we could separate out this patch into its own file. |
Collaborator
Author
|
Dan, distribution code is pretty simple so this is not adding any burden to my rebases |
Member
|
Ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antonio Murdaca [email protected]