tests/integration/test_storage.sh

[baude]

Description

Use findmnt to detect mounts.

[ashcrow]

+ '[' TARGET SOURCE FSTYPE OPTIONS /var/mnt /dev/vdb ext4 rw,relatime,seclabel,data=ordered /sysroot/ostree/deploy/centos-atomic-host/var/mnt /dev/vdb ext4 rw,relatime,seclabel,data=ordered ']'
./tests/integration/test_storage.sh: line 38: [: too many arguments
+ wipefs -a /dev/vdb
wipefs: error: /dev/vdb: probing initialization failed: Device or resource busy

[jlebon]

So this is interesting. To be helpful, the ephemeral disk that OpenStack attaches already has a filesystem on it. E.g. /dev/vdb is an ext4 partition, which is rather unusual. So maybe what we can do here is, in the YAML, do a umount /dev/vdb. And then in the env stanza export e.g. a TEST_STORAGE_DEV=/dev/vdb env var, which gets picked up in test_storage.sh. That way, local devs can set their own block device there.

And then to make sure that all partitions on the device are unmounted, do something like (untested):

findmnt -o SOURCE | grep "^$TEST_STORAGE_DEV" | xargs umount

[ashcrow]

Getting closer:

umount: /dev/vdb: not mounted

[jlebon]

What I mean is, this should be defined externally rather than hardcoded. It's not guaranteed to be /dev/vdb on every machine where this test is going to run.

[baude]

I understood, we just aren't there quite yet. Because this is a destructive test, it usually is only run under vagrant and here. @jlebon i'm actually wondering that if the device isn't declared as an environment variable, the test should just be skipped as well.

[baude]

i guess that is the point of the destructive env variable

[jlebon]

Try something like:

findmnt -o SOURCE | grep "^$TEST_DEV_1" | uniq | xargs -r umount

[rh-atomic-bot]

☔ The latest upstream changes (presumably d4fd659) made this pull request unmergeable. Please resolve the merge conflicts.

[baude]

@rh-atomic-bot r+ 17dec2d

[rh-atomic-bot]

⌛ Testing commit 17dec2d with merge b829264...

[rh-atomic-bot]

☀️ Test successful - status-redhatci
Approved by: baude
Pushing b829264 to master...