This repository was archived by the owner on Oct 10, 2020. It is now read-only.
Replace tarfile with tar on ostree import#1007
Closed
ashcrow wants to merge 2 commits intoprojectatomic:masterfrom
Closed
Replace tarfile with tar on ostree import#1007ashcrow wants to merge 2 commits intoprojectatomic:masterfrom
ashcrow wants to merge 2 commits intoprojectatomic:masterfrom
Conversation
Contributor
Author
|
@giuseppe PTAL |
Contributor
Author
|
centos error is: |
Collaborator
|
bot, retest this please |
A bug exists where tarfile.extractall raises a unicode error on some tars. This change replaces the extractall causing BZ#1451697 with the system tar command. References: - https://bugzilla.redhat.com/show_bug.cgi?id=1194473 - https://bugzilla.redhat.com/show_bug.cgi?id=1451697
Contributor
Author
|
Force pushed to get a retest. |
Collaborator
rh-atomic-bot
pushed a commit
that referenced
this pull request
May 18, 2017
A bug exists where tarfile.extractall raises a unicode error on some tars. This change replaces the extractall causing BZ#1451697 with the system tar command. References: - https://bugzilla.redhat.com/show_bug.cgi?id=1194473 - https://bugzilla.redhat.com/show_bug.cgi?id=1451697 Closes: #1007 Approved by: giuseppe
|
💔 Test failed - status-redhatci |
Contributor
Author
and |
Contributor
Author
|
@jlebon any known issues with the bot on centos? |
Member
|
@ashcrow looks like a legit test failure? |
Member
|
have you tried locally? |
Contributor
Author
|
@baude hrm. I didn't modify that test code. It's failing at: MNT=$(mount | awk '$1 ~/vdb/' | awk '{print $3}')
if [ ${MNT} ]; then
umount $MNT
fiI'll take a look in a few. |
Contributor
Author
|
#1005 is failing with the same error |
Contributor
Author
|
Related: ostreedev/ostree#859 |
Contributor
Author
|
Disabling |
test_storage.sh is erroring on centos_atomic with the following:
error: /dev/vdb: probing initialization failed: Device or resource
busy
A few quick attempts to fix it were made, but ended up failing.
Disabling (by appending an underscore) the test until it can be
investigate further.
Contributor
Author
|
Timed out trying to get a layer. 🤞 I feel good about this one! |
Contributor
Author
|
@baude PTAL |
Member
rh-atomic-bot
pushed a commit
that referenced
this pull request
May 18, 2017
test_storage.sh is erroring on centos_atomic with the following:
error: /dev/vdb: probing initialization failed: Device or resource
busy
A few quick attempts to fix it were made, but ended up failing.
Disabling (by appending an underscore) the test until it can be
investigate further.
Closes: #1007
Approved by: baude
|
☀️ Test successful - status-redhatci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A bug exists where
tarfile.extractallraises a unicode error on sometars. This change replaces the
extractallcausing BZ#1451697 withthe system tar command.
Related Bugzillas