This repository was archived by the owner on Feb 7, 2023. It is now read-only.
selinux_verify: stop checking backup files#176
Merged
miabbott merged 1 commit intoprojectatomic:masterfrom Jun 13, 2017
Merged
Conversation
New composes done with `rpm-ostree` will have the backups of the `passwd` removed, per coreos/rpm-ostree#693. This will cause the `selinux_verify` role to fail. Since we are already checking the primary file, consensus says that it is safe to remove the checks on that particular backup, as well as the other backups of `group`, `shadow`, and `gshadow`.
Member
|
👍 |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New composes done with
rpm-ostreewill have the backups of thepasswdremoved, per coreos/rpm-ostree#693. This will causethe
selinux_verifyrole to fail.Since we are already checking the primary file, consensus says that
it is safe to remove the checks on that particular backup, as well
as the other backups of
group,shadow, andgshadow.