Skip to content

Conversation

@ashetty1
Copy link

No description provided.

@optak
Copy link
Collaborator

optak commented Sep 22, 2016

What is the motivation for this PR, @ashetty1 ? We have mostly code here, I know about no plans to have plans together with code.
And it's also relatively easy plan, I think it would be much better to have just well documented code.
Note that amit already wrote these tests, if there is anything missing in that code, please add it there.

Does anyone want to have such plans here? If not, I would like to cancel this PR.

@ashetty1
Copy link
Author

@optak you had asked me to submit this testplan as a PR, and I thought you meant sending a PR here.

@optak
Copy link
Collaborator

optak commented Sep 22, 2016

No @ashetty1, I definitely didn't requested landrush testplan. If something, it was test code. It's tracked in JBQA-12948, which has been close, probably by accident. I'm going to reopen it.
What doc I wanted you to create, was contribution guideline (part of README.md), as discussed in JBQA-12877.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants