Fix: typo and deadlink #2380
Open
Fix: typo and deadlink #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davidffry
requested review from
rchincha,
andaaron and
eusebiu-constantin-petu-dbk
as code owners
eusebiu-constantin-petu-dbk
approved these changes
Apr 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2380 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 167 167
Lines 22057 22057
=======================================
Hits 20482 20482
Misses 982 982
Partials 593 593 ☔ View full report in Codecov by Sentry. |
rchincha
reviewed
Apr 10, 2024
| @@ -702,7 +702,7 @@ In order to test the Metrics feature locally in a [Kind](https://kind.sigs.k8s.i | |||
| ## Storage Drivers | |||
|
|
|||
| Beside filesystem storage backend, zot also supports S3 storage backend, check below url to see how to configure it: | |||
| - [s3 config](https://github.com/docker/docker.github.io/blob/master/registry/storage-drivers/s3.md): A driver storing objects in an Amazon Simple Storage Service (S3) bucket. | |||
| - [s3 config](https://github.com/docker/docker.github.io/blob/master/registry/storage-drivers/s3.md): A driver storing objects in an Amazon Simple Storage Service (S3) bucket. **_[ NO DOCUMENTATION --- DEAD LINK ] MAYBE THIS ONE BUT NO EXPLICIT S3 Documentation : https://github.com/docker/docs/tree/main/content/storage -- there is this : https://github.com/docker/docs/blob/5f94cb4f31535cef234fd52c5268660a7c4fe514/content/build/cache/backends/s3.md#L4 but not convinient_** | |||
There was a problem hiding this comment.
https://github.com/docker/docs/blob/main/content/build/cache/backends/s3.md
^ also works, but I would defer to our docs maintained under https://zotregistry.dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.