fix: excessive memory usage #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eusebiu-constantin-petu-dbk
requested review from
Andreea-Lupu,
laurentiuNiculae,
andaaron and
rchincha
eusebiu-constantin-petu-dbk
force-pushed
the
stream_shasums
branch
2 times, most recently
from
2c7fcd4 to
1316464
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2164 +/- ##
==========================================
- Coverage 92.15% 92.14% -0.01%
==========================================
Files 165 165
Lines 28768 28751 -17
==========================================
- Hits 26510 26493 -17
+ Misses 1664 1663 -1
- Partials 594 595 +1 ☔ View full report in Codecov by Sentry. |
andaaron
reviewed
Jan 12, 2024
eusebiu-constantin-petu-dbk
force-pushed
the
stream_shasums
branch
from
1316464 to
7732ef6
Compare
|
@peusebiu can we see the effect of this change when a image with several large blobs need to be scrubbed? |
eusebiu-constantin-petu-dbk
force-pushed
the
stream_shasums
branch
from
7732ef6 to
03a4b94
Compare
Ok I needed to handle a lock case, so I made an update to add a new storage method which doesn't lock. Yes tested it and no memory spike at all, on my machine is stays on a steady 1.3% memory, on main it has a lot of spikes when it's digesting big blobs. |
andaaron
reviewed
Jan 15, 2024
eusebiu-constantin-petu-dbk
force-pushed
the
stream_shasums
branch
2 times, most recently
from
190db9a to
1d89d99
Compare
instead of reading entire files before calculating their digests stream them by using their Reader method. Signed-off-by: Petu Eusebiu <[email protected]>
andaaron
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of reading entire files before calculating their digests stream them by using their Reader method.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.