feat(cve): add option to exclude string from cve search #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentiuNiculae
requested review from
shimish2,
rchincha,
andaaron and
eusebiu-constantin-petu-dbk
as code owners
laurentiuNiculae
force-pushed
the
exclude-search-for-cve
branch
from
e4b37b6 to
af51bcc
Compare
|
Please add test to verify CVEs which would normally match the search string parameter are excluded from the results. Please also check the test failures. |
laurentiuNiculae
force-pushed
the
exclude-search-for-cve
branch
3 times, most recently
from
5671b84 to
e44ccdb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2163 +/- ##
==========================================
+ Coverage 92.14% 92.19% +0.04%
==========================================
Files 166 166
Lines 28795 28776 -19
==========================================
- Hits 26534 26529 -5
+ Misses 1665 1655 -10
+ Partials 596 592 -4 ☔ View full report in Codecov by Sentry. |
laurentiuNiculae
force-pushed
the
exclude-search-for-cve
branch
2 times, most recently
from
4ce742f to
1c2d778
Compare
andaaron
previously approved these changes
Jan 17, 2024
Signed-off-by: Laurentiu Niculae <[email protected]>
laurentiuNiculae
force-pushed
the
exclude-search-for-cve
branch
from
1c2d778 to
aa3b898
Compare
andaaron
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.