feat(config): handle config files with no explicit extension #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eusebiu-constantin-petu-dbk
requested review from
rchincha and
andaaron
as code owners
eusebiu-constantin-petu-dbk
force-pushed
the
viper_config_no_ext
branch
from
c73f704 to
345f6d2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2147 +/- ##
==========================================
- Coverage 92.15% 92.14% -0.01%
==========================================
Files 165 165
Lines 28768 28788 +20
==========================================
+ Hits 26510 26527 +17
- Misses 1664 1667 +3
Partials 594 594 ☔ View full report in Codecov by Sentry. |
eusebiu-constantin-petu-dbk
force-pushed
the
viper_config_no_ext
branch
2 times, most recently
from
90d6e84 to
953e026
Compare
eusebiu-constantin-petu-dbk
requested review from
laurentiuNiculae,
adodon2go and
Andreea-Lupu
eusebiu-constantin-petu-dbk
force-pushed
the
viper_config_no_ext
branch
from
953e026 to
91c90e9
Compare
andaaron
reviewed
Dec 28, 2023
eusebiu-constantin-petu-dbk
force-pushed
the
viper_config_no_ext
branch
from
91c90e9 to
6bc2f93
Compare
andaaron
reviewed
Jan 11, 2024
eusebiu-constantin-petu-dbk
force-pushed
the
viper_config_no_ext
branch
2 times, most recently
from
aab666c to
8e5ce30
Compare
andaaron
approved these changes
Jan 15, 2024
eusebiu-constantin-petu-dbk
force-pushed
the
viper_config_no_ext
branch
from
8e5ce30 to
efd1fd1
Compare
Signed-off-by: Petu Eusebiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.