-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix Examples Readme to use proper field repositories
instead of repoNames
#2074
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2074 +/- ##
==========================================
- Coverage 91.88% 91.85% -0.04%
==========================================
Files 164 164
Lines 27992 27992
==========================================
- Hits 25721 25712 -9
- Misses 1676 1684 +8
- Partials 595 596 +1 ☔ View full report in Codecov by Sentry. |
@ericgraf can you pls. fix the CI failures? Commit msgs should begin with "docs: ..." and pls (GPG) sign your commits. |
@ericgraf sorry, needs some clarification. After that, |
…cies.repositories. Signed-off-by: ericgraf <[email protected]>
@rchincha Let me know if there is anything else I missed. |
@ericgraf One last one nitpick which is tripping the DCO check. sign-off not found for commit author: ericgraf [email protected]; found: ['ericgraf [email protected]'] Your git.config.email is somehow different vs |
Hi @ericgraf, please use |
What type of PR is this?
Documentation
Which issue does this PR fix:
N/A
What does this PR do / Why do we need it:
Fix documentation to use proper field called repositories instead of repoNames. This looks like an accidental mix up with the variable name used in code vs configuration field in this change #1866 .
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
None this is a documentaion change.
Automation added to e2e:
Will this break upgrades or downgrades?
Nope only a documentation change.
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.