Skip to content

Conversation

jonathanvila
Copy link
Member

@jonathanvila jonathanvila commented Jan 14, 2020

There are 3 issues covered inside :

  • VM without HOST
  • HOST without CLUSTER
  • HOST or VM without Total CPUs

These issues can happen because the attribute doesnt exist , or because it has the wrong value type.
Also this PR includes a Handler used to log the details of those Exceptions , but can be extended to persite the info in DB, etc.
Every use case has a json file in resources folder and EndToEnd test uses them to execute the analysis and then asses the values received.

This PR is blocked by https://issues.redhat.com/browse/MIGENG-328 , as there are some changes to do in xavier-analytics to relax the filtering out of vms if certain fields are null

jonathan added 20 commits January 8, 2020 16:06
…oryCalculator

added abstract clause to AbstractVMWorkloadInventoryCalculator
Added method to avoid ClassCastException on reading from JSON
Added conditional to avoid setting a default hasRdmDisk
@codecov-io
Copy link

codecov-io commented Jan 14, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@60c7663). Click here to learn what that means.
The diff coverage is 82.22%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #68   +/-   ##
=========================================
  Coverage          ?   78.85%           
  Complexity        ?      732           
=========================================
  Files             ?       71           
  Lines             ?     2038           
  Branches          ?       93           
=========================================
  Hits              ?     1607           
  Misses            ?      373           
  Partials          ?       58
Impacted Files Coverage Δ Complexity Δ
...jboss/xavier/integrations/SpringConfiguration.java 0% <0%> (ø) 0 <0> (?)
...ss/issuehandling/AnalysisIssuesHandlerLogging.java 100% <100%> (ø) 3 <3> (?)
...ics/pojo/output/workload/summary/ScanRunModel.java 96.42% <100%> (ø) 14 <4> (?)
...ss/xavier/integrations/route/MainRouteBuilder.java 98.98% <100%> (ø) 30 <0> (?)
.../migrationanalytics/business/ParamsCalculator.java 100% <100%> (ø) 14 <8> (?)
...usiness/AbstractVMWorkloadInventoryCalculator.java 78.57% <60%> (ø) 14 <1> (?)
...lytics/business/VMWorkloadInventoryCalculator.java 95.65% <88.88%> (ø) 8 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60c7663...1b43901. Read the comment docs.

@jonathanvila jonathanvila added the Depends on another PR Depends on another PR to be merged label Jan 15, 2020
@jonathanvila jonathanvila added Ready for review The PR is ready to be reviewed and removed Depends on another PR Depends on another PR to be merged labels Jan 21, 2020
@m-brophy m-brophy self-requested a review January 22, 2020 09:58
@PhilipCattanach
Copy link

Tested in CI with AllScripts payload and a test file that had manually added data integrity issues and the payload were successfully uploaded with sensible defaults.

@m-brophy m-brophy merged commit 4c917d8 into project-xavier:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants