-
Notifications
You must be signed in to change notification settings - Fork 8
Migeng 327 avoid crashes based on issues use cases #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migeng 327 avoid crashes based on issues use cases #68
Conversation
…oryCalculator added abstract clause to AbstractVMWorkloadInventoryCalculator
…to avoid division By Zero
Added method to avoid ClassCastException on reading from JSON Added conditional to avoid setting a default hasRdmDisk
… 3 issues use cases
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=========================================
Coverage ? 78.85%
Complexity ? 732
=========================================
Files ? 71
Lines ? 2038
Branches ? 93
=========================================
Hits ? 1607
Misses ? 373
Partials ? 58
Continue to review full report at Codecov.
|
modified asserts on "No ..... defined"
...s/xavier/integrations/migrationanalytics/business/AbstractVMWorkloadInventoryCalculator.java
Outdated
Show resolved
Hide resolved
Tested in CI with AllScripts payload and a test file that had manually added data integrity issues and the payload were successfully uploaded with sensible defaults. |
There are 3 issues covered inside :
These issues can happen because the attribute doesnt exist , or because it has the wrong value type.
Also this PR includes a Handler used to log the details of those Exceptions , but can be extended to persite the info in DB, etc.
Every use case has a json file in resources folder and EndToEnd test uses them to execute the analysis and then asses the values received.
This PR is blocked by https://issues.redhat.com/browse/MIGENG-328 , as there are some changes to do in xavier-analytics to relax the filtering out of vms if certain fields are null