Genkai10 (Puissance and Atori fight) #1084

kaincenteno · 2020-09-09T07:42:47Z

I affirm:

that I agree to Project Topaz's Limited Contributor License Agreement, as written on this date
that I've tested my code since the last commit in the PR, and will test after any later commits

Would love a tester to go through genkai completely.

this includes both quests and olde rarab tail GET

zach2good

This is all looking very neat and clear, looks good to me :)

Just some style things, I'd like to see some testing reports before I sign off on this.

scripts/globals/mobskills/howling_fist.lua .lua

scripts/globals/mobskills/ascetics_fury.lua

scripts/zones/Waughroon_Shrine/bcnms/beyond_infinity.lua

sql/item_usable.sql

zach2good · 2020-09-09T09:11:59Z

IBM gave me a really good explanation of different packet and move types (which I still haven't sat down to read correctly), I wonder if this can kick off the discussion of combining weaponskills.sql and mob_skills.sql

@TeoTwawki thoughts?

jarmengaud · 2020-09-09T18:16:59Z

My comments with some tests I have made on this branch:

The Beyond Infinity quest is never flagged active. This prevent getting an Olde Rarab Tail from Degenhard
When you trade your Seasoning Stone to the moogle, if in the cuscene you select that "You are not ready",
you should not be teleported to BCNM area but you should have the temp KI and the quest Beyond Infinity should me marked active.
When you enter the BCNM, you do not lose the temp KI on entry, and as such you are able to retry without checking the moogle again (so I could not test if trading one merit point or 5 High kindred crests work to get back KI)
Atori does not aggro (should be sight aggro i think)

TeoTwawki · 2020-09-09T22:27:24Z

IBM gave me a really good explanation of different packet and move types (which I still haven't sat down to read correctly), I wonder if this can kick off the discussion of combining weaponskills.sql and mob_skills.sql

@TeoTwawki thoughts?

@zach2good we've had a few talks about this on past issues pr and in discord - merging of a lot of commonality between the 2 needs to eventually happen. the parts that need to be specific to each could still go in same global that'd be fine. But we need to rework things to use an attacker/defender paradigm instead of player/mob or mob/player, migrate some parts out of character utils/entity into battle utils/entity, etc.

Right now ws global assumes user is always a player, but these ws scripts rightly should use actual ws functionality instead of faking it and guessing numbers to simulate the right dmg. Right now that's not possible, we need to sit down and make it possible. Its gonna be its own project,

TeoTwawki · 2020-09-10T00:06:31Z

Atori does not aggro (should be sight aggro i think)

@jarmengaud on retail he stands there till you attack him. Maat does the same thing allowing thf to start with an Sneak Attack even.

kaincenteno · 2020-09-10T00:36:17Z

Atori does not aggro (should be sight aggro i think)

@jarmengaud on retail he stands there till you attack him. Maat does the same thing allowing thf to start with an Sneak Attack even.

Check https://youtu.be/2ShT8fuvPV4?t=98 No provoke or any abilities were used and he starts attacking tank.

kaincenteno · 2020-09-10T03:48:22Z

@TeoTwawki

https://youtu.be/usNZOGDq5c0?t=1544

^ video by IBM :D

zach2good · 2020-09-10T04:53:33Z

If removing the KI is an issue, it doesn't look like theres any situation where you can enter the BCNM fights and not have the KI removed (or the var set), so you can do it without the check (Like in Limbus entry):

topaz/scripts/zones/Apollyon/bcnms/nw_apollyon.lua

Lines 28 to 32 in 831b8fe

    
           function onBattlefieldEnter(player, battlefield) 
        
               player:delKeyItem(tpz.ki.COSMOCLEANSE) 
        
               player:delKeyItem(tpz.ki.RED_CARD) 
        
               player:setCharVar("Cosmo_Cleanse_TIME", os.time()) 
        
           end

There is no need to fear delKeyItem, keyitems are pretty much just flags assigned to the player that you switch on and off:

    void delKeyItem(CCharEntity* PChar, uint16 KeyItemID)
    {
        auto table = KeyItemID / 512;
        PChar->keys.tables[table].keyList[KeyItemID % 512] = false;
    }

kaincenteno · 2020-09-10T05:30:53Z

If removing the KI is an issue, it doesn't look like theres any situation where you can enter the BCNM fights and not have the KI removed (or the var set), so you can do it without the check (Like in Limbus entry):

topaz/scripts/zones/Apollyon/bcnms/nw_apollyon.lua

Lines 28 to 32 in 831b8fe

function onBattlefieldEnter(player, battlefield)

player:delKeyItem(tpz.ki.COSMOCLEANSE)

player:delKeyItem(tpz.ki.RED_CARD)

player:setCharVar("Cosmo_Cleanse_TIME", os.time())

end

There is no need to fear delKeyItem, keyitems are pretty much just flags assigned to the player that you switch on and off:
    void delKeyItem(CCharEntity* PChar, uint16 KeyItemID)
    {
        auto table = KeyItemID / 512;
        PChar->keys.tables[table].keyList[KeyItemID % 512] = false;
    }

I haven't had that issue of the KI not being removed. I have asked @UynGH to take a look as I havent been able to reproduce. They Var is needed only for people that are currently on the quest otherwise it will leave an orphaned variable that will be never get erased, and we know we don't want that, isn't that right @TeoTwawki ? 😄

kaincenteno · 2020-09-10T05:36:23Z

@jarmengaud changes done, atori should now aggro, i havent had issues with the keyitem not being removed, are you sure you are add SOUL_GEM_CLASP and not just SOUL_GEM? I asked @UynGH to test this BCNM.

About the
The Beyond Infinity quest is never flagged active. This prevent getting an Olde Rarab Tail from Degenhard
When you trade your Seasoning Stone to the moogle, if in the cuscene you select that "You are not ready",
you should not be teleported to BCNM area but you should have the temp KI and the quest Beyond Infinity should me marked active. I'll try to fix it tomorrow, csid 10045 has WAAAAY lot of options it's been a headache lol

ghost · 2020-09-10T15:22:58Z

Had the same issues as Tokenr.

Prelude to Puissance

https://youtu.be/usNZOGDq5c0?t=256 (ibm's video), even if he trade unwanted items with the Seasoning Stone, the Moogle will accept said Stone and complete the quest. On canary (with your PR in) you can only trade Stone only if you want him to accept it.

https://youtu.be/usNZOGDq5c0?t=350: when you have the cutscene with Atori-Tutori (right after trading the Seasoning Stone) and you choose to make him wait, once you talk back to the Moogle (without zoning/flagging something else), he should ask "Are you ready to meet you mak--er, your final challenge, kupo?" (timestamped link). Instead, it replays the cutscene like you just traded the Stone (it should if you flag/do something else, timestamp: https://youtu.be/usNZOGDq5c0?t=597).

Beyond Infinity (limit break 10)

No "Obtained key item: Soul gem clasp." message (https://youtu.be/usNZOGDq5c0?t=644) but still listed in temporary key items. Beyond Infinity was not flagged like it should so I was unable to get an Olde Rarab Tail (yet still able to get in the BCNM). Since it wasn't flagged, not able to retry the retail way (https://youtu.be/usNZOGDq5c0?t=1369), instead I just got the same cutscene you get when you trade the Seasoning Stone for Prelude to Puissance. Soul gem clasp not deleted upon the BCNM entry, making it possible to do it endlessly even after defeating Atori-Tutori (Season Stone cutscene in a loop when you talk back to the Moogle).

Also, by comparing with the above video, the cutscene upon defeating him should start right away when his HPs reach 0 (currently it starts when his name disappear).
I got a Kindred Seal from him, I guess I shouldn't. He drops nothing.
I didn't receive any scroll of Instant Warp when I got warped to the BCNM exit (https://youtu.be/usNZOGDq5c0?t=3085).
Missing the "If all party members' HP are still zero after 3 minutes, the party will be removed from the battlefield." message if you fail.

A big thank you to ibm.

N.B. Atori-Tutori does aggro now, with your last changes.

TeoTwawki · 2020-09-10T23:53:54Z

@TeoTwawki

https://youtu.be/usNZOGDq5c0?t=1544

^ video by IBM :D

da fuq. when I want after him on my thf I swear to god he just stood there till I engaged...I need to go rematch him now. Something something mandela effect #BlameTheLHC

kaincenteno · 2020-09-11T05:48:53Z

@UynGH and @jarmengaud :

I have made changes to this to make it as much retail like which has always been my goal =)

Prelude to Puissance

Seasoning stone should now be accepted along other random nonsense lol
extra CS have been added

Beyond Infinity (limit break 10)

Soul Gem Clasp dialog will not show up as after adding it and teleporting they are done at the same time so it doesnt allow the client a breather (is the same issue with warp 2), @TeoTwawki mentioned a fix but i'll leave it to someone to fix it as its just a cosmetic issue that is experienced by other teleports too.
About the CS, thats an issue with all BCNMs ^^;; AFAIK. (Developer please tell me otherwise)
about the beastman seal drop.... its dropID is set to "0" >.< unsure what could be causing this. >.<

Can you please retest and see all those CS and keyitems work? I tested it myself but would love a second set of eyes <3

jarmengaud · 2020-09-11T16:41:22Z

As i said in discord, there is still a missing code line to set the BEYOND_INFINITY quest to ACCEPTED.
Which prevents getting the rarab tail and explain why you dont lose the KI on entry.

kaincenteno · 2020-09-12T03:16:53Z

Made more changes:

Prelude to Puissance
fixed CS as quest is completed on trade.

Beyond Infinity (limit break 10)

It now is able to be completed if not choosing the selection to not teleport and wait instead.

issue with Atori not sheating his knucle weapons when attacking and removing it when losing aggro is not implemented. Creating an issue for it.

@zach2good this is ready for review now, leaving the issue of it dropping seal (sometimes) and the knucle weapon sheating/unsheating to be fixed afterwards as it doesn't break completion of quest. =)

zach2good · 2020-09-12T09:34:15Z

I'm not going to be able review this for a few days, but I'll merge your SQL changes straight into release so your changes stop getting trampled 🙏

kaincenteno · 2020-09-12T14:42:52Z

don't worry @zach2good . its already conflicting =/ I'll have to rebase and fix it.

kaincenteno · 2020-09-12T15:41:51Z

yeah tried rebasing, i dunno what went wrong, i'll leave this alone ^^;;

ghost · 2020-09-12T16:48:20Z

Quoting my precedent message to compare what's still going on and what's fixed with the latest commit.

Prelude to Puissance

https://youtu.be/usNZOGDq5c0?t=256 (ibm's video), even if he trade unwanted items with the Seasoning Stone, the Moogle will accept said Stone and complete the quest. On canary (with your PR in) you can only trade Stone only if you want him to accept it. Still present.

https://youtu.be/usNZOGDq5c0?t=350: when you have the cutscene with Atori-Tutori (right after trading the Seasoning Stone) and you choose to make him wait, once you talk back to the Moogle (without zoning/flagging something else), he should ask "Are you ready to meet you mak--er, your final challenge, kupo?" (timestamped link). Instead, it replays the cutscene like you just traded the Stone (it should if you flag/do something else, timestamp: https://youtu.be/usNZOGDq5c0?t=597). Fixed.

Beyond Infinity (limit break 10)

No "Obtained key item: Soul gem clasp." message (https://youtu.be/usNZOGDq5c0?t=644) but still listed in temporary key items. Still present.
Beyond Infinity was not flagged like it should so I was unable to get an Olde Rarab Tail (yet still able to get in the BCNM). Since it wasn't flagged, not able to retry the retail way (https://youtu.be/usNZOGDq5c0?t=1369), instead I just got the same cutscene you get when you trade the Seasoning Stone for Prelude to Puissance. Soul gem clasp not deleted upon the BCNM entry, making it possible to do it endlessly even after defeating Atori-Tutori (Season Stone cutscene in a loop when you talk back to the Moogle). Fixed.

Also, by comparing with the above video, the cutscene upon defeating him should start right away when his HPs reach 0 (currently it starts when his name disappear). Still present.
I got a Kindred Seal from him, I guess I shouldn't. He drops nothing. Still present.
~~I didn't receive any scroll of Instant Warp when I got warped to the BCNM exit (https://youtu.be/usNZOGDq5c0?t=3085).~~ Fixed.
Missing the "If all party members' HP are still zero after 3 minutes, the party will be removed from the battlefield." message if you fail. Still present.

A big thank you to ibm.

N.B. Atori-Tutori does aggro now, with your last changes.

Be aware that all the videos are from retail (thanks to ibm and his captures).

Olde Rarab Tail mini-quest - Degenhard

Dialog when checking him a second time after he asked for the materials should be the same as the one he gives you after you traded your stuff once (https://youtu.be/usNZOGDq5c0?t=788), currently he's repeating the first one only.
Repeating the quest quest - OKAY.
Same "multi trade" issue (https://youtu.be/usNZOGDq5c0?t=797) as in the Prelude to Puissance quest, quoted from my message above.
Using an Olde Rarab Tail on other mobs should do nothing: https://youtu.be/usNZOGDq5c0?t=1071. Currently I can use it on random mobs (it does nothing but still).

BCNM

There's two different versions of the BCNM if you're comparing with YouTube videos.
The old one has different messages, an Hundred Fists animation and when using an Olde Rarab Tail, Atori-Tutori used to run around the arena.
THIS IS NOT THE TARGETED VERSION.
https://forum.square-enix.com/ffxi/threads/22099-March-27-2012-(JST)-Version-Update

[dev1095] Limit Break Quest "Beyond Infinity" Adjustments
The effect of the Olde Rarab Tail item has been altered.
Effect duration has been extended.
Your opponent will be inflicted with Terror during this time.
Your opponent will not unleash weapon skills immediately after the effect wears off.

I'm losing the Soul gem clasp key item upon entry but no message stating it/no record message/no party limitation message: https://youtu.be/usNZOGDq5c0?t=1510), should be seen if you retry too. instead I'm getting this:

Which is not present on retail.
Atori-Tutori use H2H animation when hitting, wearing a red glowing H2H weapon. There's no additional effect when he's hitting, missing the additional effect on hit he has on retail, which is really potent: https://youtu.be/0AhtvL9nRQw?t=118.
Atori-Tutori used no WSs at all. On retail he use them pretty often, even after a few hits and he does skillchains by using them back to back: https://youtu.be/Q7ncfLXEPNE?t=396. This make it impossible to see if the WSs messages are working.
No message saying he used Hundred Fists but I got one when it wore off, while it should be the other way around: https://youtu.be/usNZOGDq5c0?t=2783. Not having any animation is good tho!

Duration of the Olde Rarab Tail seems to be 1 minute and 33 seconds everytime on retail - OKAY:

https://www.youtube.com/watch?v=usNZOGDq5c0:
44:46 > 46:19.
46:30 > 48:03.
https://www.youtube.com/watch?v=0AhtvL9nRQw:
2:07 > 3.40.

Possibility to exit the BCNM and it counts as failing - OKAY.
No message when he defeats you: https://youtu.be/usNZOGDq5c0?t=1254. Since there's no 3 minutes delay you're directly teleported out of the BCNM.

BCNM retry

Everything went good when trading 5 High Kindred's Crest. - OKAY.
I didn't lose the merit point needed when I tried to pay with it (https://youtu.be/usNZOGDq5c0?t=1636 ibm went from 12 to 11) but I was still able to select a location to teleport to.
In both cases I got the "Obtained key item: Soul gem clasp." message correctly when refusing to teleport directly (choosing "Nowhere yet." https://youtu.be/usNZOGDq5c0?t=1440) so you might take a look here to get the message where's it's missing above.
Having 0 merit point in stock will give the High Kindred's Crest message only: https://youtu.be/usNZOGDq5c0?t=2399 - OKAY.

Ending CS with the Nomad Moogle after completing the BCNM - OKAY.

Bonus: Typos for Horlais Peak and Waughroon Shrine!

changed humanoid-tarutaru to aggro on sight increased level from 95 to 102 as got report that his fight was too easy. commented that both quests are completable

…sance created local var for handling missing CS that only happens if trading and staying in location created charvar to be used after trading stone but not yet accepting beyond infinity cleaned up onEventFinish for each option to make it clear so whomever takes over this NPC is able to clean it up a little or easier to understand to implement WS quest that is missing

…e its own option ID fixed several startevents and issue of quest not being accepted.

zach2good · 2020-09-13T15:05:51Z

Looks very good and clean.

From Nyu's post it looks like there's still a couple of things left to do. Don't worry about BCNM timers, messaging, despawning etc. Those are all issues with the BCNM system. Try to get all the trading and quest stuff perfect, and maybe the aesthetic things if you can, but those aren't a requirement.

zach2good suggested changes Sep 9, 2020

View reviewed changes

kaincenteno and others added 6 commits September 12, 2020 16:03

clean branch for PR

1445dae

fixed subjob allowed in BCNM and level cap to 99

6b44a68

changed humanoid-tarutaru to aggro on sight increased level from 95 to 102 as got report that his fight was too easy. commented that both quests are completable

fixed style and renamed wrong file

dca6b61

Fixes BEYOND INFINITY not being added (incorrectly adding prelude again)

1ce4958

added completequest inside trade as its an exception as it doesnt hav…

b809ecf

…e its own option ID fixed several startevents and issue of quest not being accepted.

zach2good changed the base branch from release to feature/genkai10 September 14, 2020 13:13

zach2good added approved Pull request has been approved reviewed Has been reviewed by at least one Staff Member labels Sep 14, 2020

zach2good merged commit 2733491 into project-topaz:feature/genkai10 Sep 14, 2020

zach2good mentioned this pull request Sep 14, 2020

Genkai 10 Issues (Prelude to Puissance & Beyond Infinity) #1137

Open

2 tasks

topaz-next-bot mentioned this pull request Dec 17, 2020

Genkai 10 Issues (Prelude to Puissance & Beyond Infinity) topaz-next/topaz#1880

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Genkai10 (Puissance and Atori fight) #1084

Genkai10 (Puissance and Atori fight) #1084

kaincenteno commented Sep 9, 2020

zach2good left a comment

zach2good commented Sep 9, 2020

jarmengaud commented Sep 9, 2020 •

edited

Loading

TeoTwawki commented Sep 9, 2020 •

edited

Loading

TeoTwawki commented Sep 10, 2020 •

edited

Loading

kaincenteno commented Sep 10, 2020

kaincenteno commented Sep 10, 2020

zach2good commented Sep 10, 2020 •

edited

Loading

kaincenteno commented Sep 10, 2020

kaincenteno commented Sep 10, 2020 •

edited

Loading

ghost commented Sep 10, 2020 •

edited by ghost

Loading

TeoTwawki commented Sep 10, 2020

kaincenteno commented Sep 11, 2020

jarmengaud commented Sep 11, 2020

kaincenteno commented Sep 12, 2020

zach2good commented Sep 12, 2020

kaincenteno commented Sep 12, 2020

kaincenteno commented Sep 12, 2020

ghost commented Sep 12, 2020 •

edited by ghost

Loading

zach2good commented Sep 13, 2020

Genkai10 (Puissance and Atori fight) #1084

Genkai10 (Puissance and Atori fight) #1084

Conversation

kaincenteno commented Sep 9, 2020

zach2good left a comment

Choose a reason for hiding this comment

zach2good commented Sep 9, 2020

jarmengaud commented Sep 9, 2020 • edited Loading

TeoTwawki commented Sep 9, 2020 • edited Loading

TeoTwawki commented Sep 10, 2020 • edited Loading

kaincenteno commented Sep 10, 2020

kaincenteno commented Sep 10, 2020

zach2good commented Sep 10, 2020 • edited Loading

kaincenteno commented Sep 10, 2020

kaincenteno commented Sep 10, 2020 • edited Loading

ghost commented Sep 10, 2020 • edited by ghost Loading

TeoTwawki commented Sep 10, 2020

kaincenteno commented Sep 11, 2020

jarmengaud commented Sep 11, 2020

kaincenteno commented Sep 12, 2020

zach2good commented Sep 12, 2020

kaincenteno commented Sep 12, 2020

kaincenteno commented Sep 12, 2020

ghost commented Sep 12, 2020 • edited by ghost Loading

zach2good commented Sep 13, 2020

jarmengaud commented Sep 9, 2020 •

edited

Loading

TeoTwawki commented Sep 9, 2020 •

edited

Loading

TeoTwawki commented Sep 10, 2020 •

edited

Loading

zach2good commented Sep 10, 2020 •

edited

Loading

kaincenteno commented Sep 10, 2020 •

edited

Loading

ghost commented Sep 10, 2020 •

edited by ghost

Loading

ghost commented Sep 12, 2020 •

edited by ghost

Loading