Employ RpcSendTransactionConfig::default() for better forward compatibility#39
Merged
Merged
Conversation
Contributor
Author
|
Red CI due to github rate limiting 💾 |
Contributor
Author
|
Same commit went green here, https://travis-ci.com/github/mvines/serum-dex/builds/192162295 |
armaniferrante
approved these changes
Oct 23, 2020
Contributor
armaniferrante
left a comment
armaniferrante
left a comment
There was a problem hiding this comment.
@mvines I reran the build. Thanks for the update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RpcSendTransactionConfigstruct is the Rust representation of sendTransaction's JSON configuration object. New fields may be added to this struct in the future as we add more configuration parameters.This PR causes the default value for new fields to be accepted without a compile error on upgrade, which follows the same semantics as the JSON object it represents.
cc: 3dc834b