Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

Fix: move rqt software check #30

Merged
merged 3 commits into from
Mar 20, 2020
Merged

Conversation

Olavhaasie
Copy link
Contributor

Description

Created new march_rqt_software_check package from the march_launch package to here. This makes the march_launch package easier to understand and the march_rqt_software_check package is a monitor tool.

I also fixed it, since the module color was incorrectly imported and I removed roslint.

Changes

  • Created march_rqt_software_check package
  • Removed roslint
  • Fixed dependencies

@Olavhaasie Olavhaasie requested a review from a team as a code owner March 19, 2020 10:17
@Olavhaasie Olavhaasie requested review from Roelemans and RutgerVanBeek and removed request for a team March 19, 2020 10:17
Copy link
Contributor

@RutgerVanBeek RutgerVanBeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it break, when I launch it not on exo? I expected the GUI to load, but the tests to fail, because I am not on exo.

@Olavhaasie
Copy link
Contributor Author

Should it break, when I launch it not on exo? I expected the GUI to load, but the tests to fail, because I am not on exo.

It should at least launch. You can perform the local tests, but not the remote ones, since it will try to connect to exo.

@Roelemans Roelemans merged commit c3f8ff7 into develop Mar 20, 2020
@Roelemans Roelemans deleted the fix/move-rqt-software-check branch March 20, 2020 12:00
@Roelemans
Copy link
Contributor

@RutgerVanBeek you should checkout project-march/march#498 as well

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants