Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

Fix setpoints pointer problems #101

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Conversation

Roelemans
Copy link
Contributor

Description

There was a bug in #100 that caused a crash when doing lock -> invert -> lock. It had something to do with pointers to setpoints which got messy when start en end point got changed around by invert. Hence, I simply set position and velocity to be equal here, instead of assigning setpoints[0] = start_point etc.

Changes

@Roelemans Roelemans requested review from a team and RutgerVanBeek and removed request for a team June 25, 2020 10:47
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #101 into develop will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #101      +/-   ##
===========================================
- Coverage    72.95%   72.91%   -0.04%     
===========================================
  Files           17       17              
  Lines         1671     1669       -2     
  Branches       186      184       -2     
===========================================
- Hits          1219     1217       -2     
  Misses         404      404              
  Partials        48       48              
Flag Coverage Δ
#production 55.38% <100.00%> (-0.09%) ⬇️
#test 99.25% <ø> (ø)
Impacted Files Coverage Δ
...ait_generator/model/modifiable_joint_trajectory.py 91.93% <100.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d624379...cc77338. Read the comment docs.

Copy link
Contributor

@Olavhaasie Olavhaasie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find 👍

@Olavhaasie Olavhaasie merged commit 7ff8e02 into develop Jun 25, 2020
@Olavhaasie Olavhaasie deleted the fix/lock-invert-relock-error branch June 25, 2020 11:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants