Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Login ViewModel Input, output 구조 개선 #24

Closed
4 tasks done
derrickkim0109 opened this issue Jun 17, 2024 · 0 comments
Closed
4 tasks done

[REFACTOR] Login ViewModel Input, output 구조 개선 #24

derrickkim0109 opened this issue Jun 17, 2024 · 0 comments
Assignees
@derrickkim0109
Labels
refactor

Comments

@derrickkim0109
Copy link
Collaborator

derrickkim0109 commented Jun 17, 2024 •
edited
Loading

어떤 기능인가요?

Combine 스트림이 끊어지지 않는 input, output 구조가 될 수 있도록 개선하는 작업입니다.

작업 상세 내용

  • Input, output struct로 선언
  • flatMap 적용
  • kakao, apple service에서 recentLoginRecordService가 아닌 Storage를 가지도록 변경
  • 각 모듈에서 사용하는 하위 모듈들 parent 모듈로 import 하도록 변경
    • FeatureOnboarding에서 import SharedUtil이 아닌 Shared로 변경
    • Tuist Project도 변경 필요

참고할만한 자료(선택)
@derrickkim0109 derrickkim0109 self-assigned this Jun 17, 2024
@derrickkim0109 derrickkim0109 mentioned this issue Jun 20, 2024
Closed
9 tasks
derrickkim0109 added a commit to derrickkim0109/app-iOS that referenced this issue Jun 24, 2024
@derrickkim0109
Merge branch 'develop' into refactor/project-lyrics#24-login-logic
a177030
derrickkim0109 added a commit to derrickkim0109/app-iOS that referenced this issue Jun 24, 2024
@derrickkim0109
Merge branch 'feature/project-lyrics#22-login-tests' into refactor/pr…
09966d0 
…oject-lyrics#24-login-logic
derrickkim0109 added a commit to derrickkim0109/app-iOS that referenced this issue Jun 29, 2024
@derrickkim0109
Merge branch 'develop' into refactor/project-lyrics#24-login-logic
28e97af
derrickkim0109 added a commit that referenced this issue Jul 4, 2024
@derrickkim0109
Refactor/#24 Login ViewModel Input, output 구조 개선 (#29)
eb38ca2 
* remove: 불필요한 모듈, 객체 제거

- RecordError
- Domain PostTextUseCase
- LoginInputOutput

* feat<SharedUtil>: CombineCococa 구현

* remove: Login view 파일 위치 이동

* refactor: Login ViewController ViewModel 방식 변경

- 파일 위치 변경
- 네이밍 변경
- input, output 방식 변경

* refactor: Coordinator Onboarding register 메서드 순서 변경

* refactor: Shared 모듈 내에 Flex Layout SDK 추가

* refactor: OAuthType enum으로 변경

* refactor: FeelinAPI URL, path 변경

* refactor: input 파라미터 네이밍 변경

* chore: 개행 제거

* chore: 개행 변경

* refactor: LoginViewController 프로퍼티 네이밍 수정
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derrickkim0109 derrickkim0109

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@derrickkim0109