-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COST-4670] Enable copy-on-write in Pandas #4980
Conversation
0e37e4e
to
9d08265
Compare
Right now this is likely a QE testing effort to evaluate the impact of any Memory improvements/degradations PRIOR to this being merged. Lets give QE time to test this and if they are satisfied they can be the ones to approve this PR for it to be merged. |
/retest |
9d08265
to
084baa2
Compare
/retest |
2 similar comments
/retest |
/retest |
f3d043d
to
f6e8a4d
Compare
f6e8a4d
to
517c6e7
Compare
/retest |
Tests are failing with Need to identify where we are doing chained assignments and update the code. |
Testing out the new behavior that will be the default in Pandas 3.0 https://pandas.pydata.org/docs/dev/whatsnew/v2.2.0.html#copy-on-write
517c6e7
to
bd1601a
Compare
bd1601a
to
303126c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4980 +/- ##
=======================================
- Coverage 94.1% 94.1% -0.0%
=======================================
Files 377 377
Lines 31375 31375
Branches 3724 3724
=======================================
- Hits 29532 29529 -3
- Misses 1173 1176 +3
Partials 670 670 |
Jira Ticket
COST-4670
Description
Enable copy-on-write in
pandas
. This should result in better memory usage and more predictable performance.Testing
Notes
If this change has no negative impact, we should enable it now.