Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change github-action cache key #2441

Merged
merged 3 commits into from
Oct 7, 2020
Merged

Change github-action cache key #2441

merged 3 commits into from
Oct 7, 2020

Conversation

maskarb
Copy link
Member

@maskarb maskarb commented Oct 7, 2020

Our github-actions cache seems corrupted again. One solution is to change the cache key so that it will be recreated.

This idea came from here: python-poetry/poetry#1928. It resolved their issues, so it should work for us too.

@maskarb maskarb changed the title temporarily disable github-action cache Change github-action cache key Oct 7, 2020
@maskarb maskarb marked this pull request as ready for review October 7, 2020 13:47
Copy link
Contributor

@adberglund adberglund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧶

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@c1d4cbd). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #2441   +/-   ##
========================================
  Coverage          ?   94.6%           
========================================
  Files             ?     249           
  Lines             ?   18017           
  Branches          ?    2046           
========================================
  Hits              ?   17043           
  Misses            ?     605           
  Partials          ?     369           

@boaz0
Copy link
Contributor

boaz0 commented Oct 7, 2020

LGTM

@maskarb maskarb merged commit 48bce64 into master Oct 7, 2020
@maskarb maskarb deleted the temp-disable-cache branch October 7, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants