Update the top level template json file based on ZCL extensions #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
brdandu
commented
Oct 28, 2024
brdandu
commented
- Add the zcl extension files to part of its crc check.
- If the crc changes based on the inclusion of extensions then reload the top level template json file and turn its IN_SYNC to true and turn the old on to false
- These changes make sure that when a zcl extension file (eg json files in zcl section such as cluster-to-component.json) is updated then everything from the top level json files are loaded again
- JIRA: ZAPP-1092
brdandu
requested review from
tecimovic,
paulr34,
ethanzhouyc,
tbrkollar and
dhchandw
tecimovic
requested changes
Oct 29, 2024
brdandu
force-pushed
the
bug/updateTopLevelTemplatePackageBasedOnZCLExtensionChanges/ZAPP-1092
branch
from
9b46e0c to
c1b487b
Compare
- Add the zcl extension files to part of its crc check. - If the crc changes based on the inclusion of extensions then reload the top level template json file and turn its IN_SYNC to true and turn the old on to false - These changes make sure that when a zcl extension file (eg json files in zcl section such as cluster-to-component.json) is updated then everything from the top level json files are loaded again - Add tests to make sure top level template json file is reloaded when the zcl extension file is modified - JIRA: ZAPP-1092
brdandu
force-pushed
the
bug/updateTopLevelTemplatePackageBasedOnZCLExtensionChanges/ZAPP-1092
branch
from
c1b487b to
f175c63
Compare
tecimovic
approved these changes
Oct 29, 2024
|
Unify CI failure is a known failure and is being looked into. Will be disabled for the short term. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.