Create a block helper to iterate over the ZCL Baseline Types: #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
brdandu
commented
Oct 25, 2024
brdandu
commented
- Add zcl_baseline_types to go over baseline types found from atomic data types
- Add additional is_power_of_two helper for matter use case to determine odd sized data types
- update the atomic table schema, retrieval and mapping
- Add unit tests with the example needed for Matter code
- update feature level pointer
- Updating the zap schema
- Github: ZAP#1438
brdandu
requested review from
bzbarsky-apple,
ethanzhouyc,
tbrkollar and
dhchandw
dhchandw
reviewed
Oct 25, 2024
dhchandw
approved these changes
Oct 28, 2024
Comment on lines
312
to
313
| (a.$.name.toLowerCase().includes('long') && | ||
| a.$.name.toLowerCase().includes('string')), |
There was a problem hiding this comment.
This seems like it would trigger on names like "stringorlong"....
| @@ -596,6 +596,9 @@ CREATE TABLE IF NOT EXISTS "ATOMIC" ( | |||
| "IS_LONG" integer default false, | |||
| "IS_CHAR" integer default false, | |||
| "IS_SIGNED" integer default false, | |||
| "IS_COMPOSITE" integer default false, | |||
| "IS_FLOAT" integer default false, | |||
| "BASE_TYPE" text, | |||
There was a problem hiding this comment.
This allows BASE_TYPE to be null? Or if not, how is "no base type" represented? Empty string?
There was a problem hiding this comment.
It will be null in this case.
| * @param {*} val | ||
| * @returns boolean | ||
| */ | ||
| function is_power_of_two(val) { |
There was a problem hiding this comment.
Seems completerly unrelated to the base type stuff.
There was a problem hiding this comment.
Yeah it is not needed but is useful for determining odd sized data types in the future.
brdandu
force-pushed
the
feature/createZClBaseLineTypeHelper/ZAP#1438
branch
from
39c5c6f to
8068758
Compare
tecimovic
approved these changes
Oct 29, 2024
brdandu
force-pushed
the
feature/createZClBaseLineTypeHelper/ZAP#1438
branch
from
8068758 to
5e9696a
Compare
…ine odd sized data types - update the atomic table schema, retrieval and mapping - Add unit tests with the example needed for Matter code - update feature level pointer - Updating the zap schema - Adding support to determine if a data type is baseline type or not from the xml itself - This is done by adding BASE_TYPE column to the atomic table and then mapping it appropriately to baseType for the zcl_atomics helper - Adding base types for derived types in the atomic xml file - This is done by adding baseType column to the atomic table and then mapping it appropriately to baseType for the zcl_atomics helper such that derived types can refer to base types Cleanup - Github: ZAP#1438
brdandu
force-pushed
the
feature/createZClBaseLineTypeHelper/ZAP#1438
branch
from
5e9696a to
7386854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.