Add Tizen docker image #8850
Merged
Add Tizen docker image #8850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst and
woody-apple
Damian-Nordic
approved these changes
Aug 9, 2021
|
/gcbrun |
andy31415
reviewed
Aug 10, 2021
andy31415
reviewed
Aug 10, 2021
bzbarsky-apple
approved these changes
Aug 11, 2021
hyunuktak
force-pushed
the
tizen
branch
2 times, most recently
from
08d7c60 to
d621752
Compare
woody-apple
approved these changes
Aug 11, 2021
andy31415
approved these changes
Aug 11, 2021
|
/gcbrun |
|
Also please bump the version a bit more - we got a merge conflict with telink image updates (which also bumped the version). |
Actually, we checked the docker image of tizen and vscode by executing an example build in tizen environment with job of git action and task of vscode. and it will come up to next PR. |
|
@andy31415 Please take a look at our latest code dealing with your comments. Thank you. 😄 |
|
One more code conflict :( |
Signed-off-by: hyunuk.tak <[email protected]>
Signed-off-by: hyunuk.tak <[email protected]>
It's one way to mitigate the CVE-2019-5736 Signed-off-by: hyunuktak <[email protected]>
I fixed conflict and rebase it :D |
msandstedt
approved these changes
Aug 12, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* Add docker image to build with Tizen platform Signed-off-by: hyunuk.tak <[email protected]> * Update chip-build-vscode image to import Tizen platform requirement Signed-off-by: hyunuk.tak <[email protected]> * Run container with a non-root user It's one way to mitigate the CVE-2019-5736 Signed-off-by: hyunuktak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
To integrate and validate Tizen port of CHIP, docker images are required to build the examples in the Github workflow.
Like other docker images used by this repository, they should be available in the
connectedhomeipdocker hub.Summary of Changes
Tizen docker image build files are located
integrations/docker/images/chip-build-tizen.The downstream image used as the development environment (
chip-build-vscode) has been updated to import build dependencies required to work with Tizen: