Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't wait for CASE connection if resolve fails in chip-device-ctrl #8161

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Don't wait for CASE connection if resolve fails in chip-device-ctrl #8161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/controller/python/chip/ChipDeviceCtrl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,14 @@ def HandleKeyExchangeComplete(err):
def HandleAddressUpdateComplete(nodeid, err):
if err != 0:
print("Failed to update node address: {}".format(err))
# Failed update address, don't wait for HandleCommissioningComplete
self.state = DCState.IDLEHandleCommissioningComplete
self._ChipStack.callbackRes = err
self._ChipStack.completeEvent.set()
else:
print("Node address has been updated")
# Wait for HandleCommissioningComplete before setting
# self._ChipStack.callbackRes; we're not done until that happens.
# Wait for HandleCommissioningComplete before setting
# self._ChipStack.callbackRes; we're not done until that happens.

def HandleCommissioningComplete(nodeid, err):
if err != 0:
Expand Down