-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate MRP message handling and test #7893
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst and
woody-apple
June 24, 2021 22:03
woody-apple
approved these changes
Jun 24, 2021
Fixes #7292 |
bzbarsky-apple
requested changes
Jun 25, 2021
/rebase |
woody-apple
force-pushed
the
crmp-duplicates
branch
from
June 26, 2021 21:12
15e7032
to
b9a8612
Compare
pan-apple
force-pushed
the
crmp-duplicates
branch
from
June 26, 2021 21:32
b9a8612
to
9ea248b
Compare
Size increase report for "gn_qpg6100-example-build" from 17dbc19
Full report output
|
Size increase report for "esp32-example-build" from 17dbc19
Full report output
|
Size increase report for "nrfconnect-example-build" from 17dbc19
Full report output
|
bzbarsky-apple
approved these changes
Jun 27, 2021
yufengwangca
approved these changes
Jun 28, 2021
@saurabhst, @mspang any feedback? |
saurabhst
approved these changes
Jun 28, 2021
mspang
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rubber stamping @yufengwangca's review
jmartinez-silabs
approved these changes
Jun 28, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* Duplicate CRMP message handling and test * address review comments * update test with review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If the MRP ack is lost, the retransmitted MRP message doesn't trigger an ack. The message counter check detects the retransmitted message as duplicate, and drops it before it could reach MRP layer.
Change overview
Detect and mark the message as duplicate. If the message requires MRP ack, let it go up the stack to the MRP layer.
The MRP and exchange layer sends the ack for the message, and drops it.
Testing
Added a new unit test
CheckDuplicateMessage
to test this condition.Also tested E2E flow using Python controller and chip-tool apps.