Level cluster Step/Move commands reverted to random value after transition

[tima-q]

Problem

A Step command did not execute as expected.
The transition happens, but when reaching the desired value it fell back to the original one.

After examination of the level-control-server.cpp code it seems a variable storedLevel is the source.
This variable is part of the state for the LevelControl cluster in case an Effect is requested (07-5123-04 (ZigBee Cluster Library doc), section 3.10.2.1.1.). The currentLevel is backed up there to restore after the effect has finished.

Backup point:

connectedhomeip/src/app/clusters/level-control/level-control.cpp

Line 938 in ed677f0

moveToLevelHandler(ZCL_MOVE_TO_LEVEL_COMMAND_ID, minimumLevelAllowedForTheDevice, currentOnOffTransitionTime, 0xFF, 0xFF,

Restore point after transition:

connectedhomeip/src/app/clusters/level-control/level-control.cpp

Line 260 in ed677f0

if (state->storedLevel != INVALID_STORED_LEVEL)

An INVALID_STORED_LEVEL is set in other commands (MoveToLevel/...) to skip the revert step.
For example:

connectedhomeip/src/app/clusters/level-control/level-control.cpp

Line 414 in ed677f0

moveToLevelHandler(ZCL_MOVE_TO_LEVEL_COMMAND_ID, level, transitionTime, optionMask, optionOverride,

However, in case of Step/Move command this variable was not initialized to prevent this reverting/setting.

Change overview

Assigning INVALID_STORED_LEVEL to the storedLevel variable where missing.

Testing

Setup:

• chip-device-ctrl on RPi4 (TE3 image) + qpg6100 lighting-application
  Scenario:
• factory reset - move through commissioning of device
• Issue step command - `zcl LevelControl Step 101 1 0 stepMode=1 stepSize=64 transitionTime=20 optionMask=0 optionOverride=0'
• Read out CurrentLevel value - zclread LevelControl CurrentLevel 101 1 0
• Check logging
  • transition is printed for each step
  • which levels are set to light
• Check LED behavior visually - not jumping back/erratic

[github-actions]

Size increase report for "gn_qpg6100-example-build" from ed677f0

File	Section	File	VM
chip-qpg6100-lighting-example.out	.text	16	16

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_line,0,21
.text,16,16
.debug_str,0,-1
[Unmapped],0,-16

[bzbarsky-apple]

@selissia could you take a look at this, please?

[selissia]

@selissia could you take a look at this, please?

Done, approved.