-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable TSAN builds on CI #7797
Enable TSAN builds on CI #7797
Conversation
Love to see failing (new) tests :) |
ccf8b19
to
26963a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filenames for the failure-case artifact uploads probably need to include matrix.type, or we (more plausibly) should only do the uploads for the non-tsan case.
26963a0
to
cf79d93
Compare
This enables TSAN checking when running the functional tests in CI. This is currently only enabled on Linux since the various races there were fixed when project-chip#7478 landed. When Darwin races are fixed, tsan can be enabled for those too.
cf79d93
to
23258ee
Compare
bikeshed: Can we change the name from no_tsan to something else? default? Naming it what it's not isn't a scalable scheme (don't want to end up calling no_tsan_no_asan_no_*). |
Or maybe "debug". |
Would |
The default is optimized for debug & test (optimizations are limited, debug-only assertions enabled, etc) which is why it is usually called "debug". These names are or should be understood in a broader context than just this workflow. "default" and "tsan" seem OK though |
bc2c996
to
ddda053
Compare
Size increase report for "nrfconnect-example-build" from 039dfbd
Full report output
|
Size increase report for "esp32-example-build" from 039dfbd
Full report output
|
Size increase report for "gn_qpg6100-example-build" from 039dfbd
Full report output
|
* Enable TSAN builds on CI for Functional Tests. This enables TSAN checking when running the functional tests in CI. This is currently only enabled on Linux since the various races there were fixed when project-chip#7478 landed. When Darwin races are fixed, tsan can be enabled for those too. * Fix-ups as per review feedback, including enabling it for Darwin * Increased timeout for tsan jobs since it takes some time! * Increased timeout for tsan jobs since it takes some time (real fix)!
This enables TSAN checking when running the functional tests in CI.
This is currently only enabled on Linux since the various races there were fixed when #7478 landed.
When Darwin races are fixed, tsan can be enabled for those too.