-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timer to reboot RPC for NRF lighting example #6892
Merged
woody-apple
merged 1 commit into
project-chip:master
from
rgoliver:chip_add_timer_rpc_reboot
May 20, 2021
Merged
Add timer to reboot RPC for NRF lighting example #6892
woody-apple
merged 1 commit into
project-chip:master
from
rgoliver:chip_add_timer_rpc_reboot
May 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/rebase |
woody-apple
force-pushed
the
chip_add_timer_rpc_reboot
branch
from
May 17, 2021 23:05
6c31290
to
6b447d5
Compare
Hi @rgoliver this needs a restyle, I tried to run it, but it appears things have diverged enough the merge won't work :( |
rgoliver
force-pushed
the
chip_add_timer_rpc_reboot
branch
from
May 18, 2021 19:35
6b447d5
to
e511abc
Compare
Add a timer to reboot after the RPC returns, this ensures the host code knows the RPC command was succesfully recieved before the device reboots. Also reboot after doing a FDR.
rgoliver
force-pushed
the
chip_add_timer_rpc_reboot
branch
from
May 19, 2021 13:28
e511abc
to
fb601db
Compare
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst and
woody-apple
May 19, 2021 13:34
Size increase report for "nrfconnect-example-build" from 4e7505f
Full report output
|
andy31415
approved these changes
May 20, 2021
jelderton
approved these changes
May 20, 2021
jmartinez-silabs
approved these changes
May 20, 2021
woody-apple
approved these changes
May 20, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Add a timer to reboot after the RPC returns, this ensures the host code knows the RPC command was succesfully recieved before the device reboots. Also reboot after doing a FDR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Reboot RPC command doesn't return Status::OK. Instead it reboots immediately before returning, which can be difficult for the host code to handle.
Summary of Changes
Add a timer to reboot after the RPC returns, this ensures the host
code knows the RPC command was successfully received before the
device reboots.
Also reboot after doing a FDR.
Testing: Verified new RPC behavior worked as expected on lighting-app RPC build, with nRF52840