Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timer to reboot RPC for NRF lighting example #6892

Merged
merged 1 commit into from
May 20, 2021

Conversation

rgoliver
Copy link

@rgoliver rgoliver commented May 17, 2021

Problem

Reboot RPC command doesn't return Status::OK. Instead it reboots immediately before returning, which can be difficult for the host code to handle.

Summary of Changes

Add a timer to reboot after the RPC returns, this ensures the host
code knows the RPC command was successfully received before the
device reboots.

Also reboot after doing a FDR.

Testing: Verified new RPC behavior worked as expected on lighting-app RPC build, with nRF52840

@woody-apple
Copy link
Contributor

/rebase

@woody-apple woody-apple force-pushed the chip_add_timer_rpc_reboot branch from 6c31290 to 6b447d5 Compare May 17, 2021 23:05
@woody-apple
Copy link
Contributor

Hi @rgoliver this needs a restyle, I tried to run it, but it appears things have diverged enough the merge won't work :(

@rgoliver rgoliver force-pushed the chip_add_timer_rpc_reboot branch from 6b447d5 to e511abc Compare May 18, 2021 19:35
Add a timer to reboot after the RPC returns, this ensures the host
code knows the RPC command was succesfully recieved before the
device reboots.

Also reboot after doing a FDR.
@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 4e7505f

File Section File VM
chip-lighting.elf text 72 72
chip-lighting.elf k_timer_area 56 56
chip-lighting.elf device_handles 8 8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_info,0,307
.debug_loc,0,107
.strtab,0,101
.debug_abbrev,0,90
.debug_line,0,87
.symtab,0,80
text,72,72
k_timer_area,56,56
.debug_str,0,25
.debug_frame,0,16
.debug_aranges,0,8
device_handles,8,8
.shstrtab,0,-1
.debug_ranges,0,-40


@woody-apple woody-apple merged commit 9783f90 into project-chip:master May 20, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Add a timer to reboot after the RPC returns, this ensures the host
code knows the RPC command was succesfully recieved before the
device reboots.

Also reboot after doing a FDR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants