Use Objective-C naming convention for Cluster method names #6442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Link to the only meaningful commit here: 6588850 |
sagar-apple
changed the title
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst,
wehale and
woody-apple
saurabhst
approved these changes
May 4, 2021
mspang
approved these changes
May 4, 2021
sagar-apple
force-pushed
the
naming_convention
branch
from
8d24238 to
36f0406
Compare
woody-apple
approved these changes
May 4, 2021
|
@sagar-apple Darwin CI broken :) |
sagar-apple
force-pushed
the
naming_convention
branch
from
648a360 to
f5eb402
Compare
vivien-apple
approved these changes
May 4, 2021
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
May 5, 2021
This is due to a merge conflict between PR project-chip#6233 nd PR project-chip#6442. The completion handlers got renamed to response handlers in the latter, but the former is still calling one of them completionHandler.
andy31415
pushed a commit
that referenced
this pull request
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Cluster APIs don't follow Objective-C naming convention. This results in less than perfect Swift interoperability.
Summary of Changes
completionHandlertoresponseHandler