Remove dead (uncompilable) code from python script bindings #4690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
determine if log redirection is supposed to be functioning in CHIPThis comment was generated by todo based on a
|
pullapprove
bot
requested review from
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple,
saurabhst,
vivien-apple and
woody-apple
woody-apple
approved these changes
Feb 5, 2021
saurabhst
approved these changes
Feb 5, 2021
mspang
approved these changes
Feb 5, 2021
|
@andy31415 unit test fail? Is that real? |
Seems green now. I do not believe these changes get unit tested at all because mostly python. |
agners
added a commit
to agners/connectedhomeip
that referenced
this pull request
Jun 3, 2024
Since project-chip#5024 there is a new logging callback working. The old code has partially been removed in project-chip#4690, but never completely. Drop the old logging code for good.
agners
added a commit
to agners/connectedhomeip
that referenced
this pull request
Jun 3, 2024
Since project-chip#5024 there is a new logging callback working. The old code has partially been removed in project-chip#4690, but never completely. Drop the old logging code for good.
agners
added a commit
to agners/connectedhomeip
that referenced
this pull request
Jun 3, 2024
Since project-chip#5024 there is a new logging callback working. The old code has partially been removed in project-chip#4690, but never completely. Drop the old logging code for good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Weave baseline supports log redirection. CHIP lost that capability (unsure why though) and the python chip bindings that were trying to use such redirection would not even compile.
Summary of Changes
Deletes the logging code, adds a todo to figure out final functionality.
Also replaced some WEAVE with CHIP - although realistically that logging does not currently work.
Long term, I believe log redirection should work in some generic way:
Updating this seems a larger task though, so for now I just cleaned it and added a TODO.