Convert mdns Builder classes to use PacketBufferHandle #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem Code should use `PacketBufferHandle` rather than `PacketBuffer` directly. #### Summary of Changes Convert mdns::Minimal::QueryBuilder and mdns::Minimal::ResponseBuilder to take and hold PacketBufferHandle. Part of issue project-chip#2707 - Figure out a way to express PacketBuffer ownership in the type system
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
saurabhst
approved these changes
Dec 4, 2020
examples/minimal-mdns/client.cpp
Outdated
| @@ -213,7 +213,7 @@ void BroadcastPacket(mdns::Minimal::ServerBase * server) | |||
| QuerySplitter query; | |||
| query.Split(gOptions.query); | |||
|
|
|||
| mdns::Minimal::QueryBuilder builder(buffer.Get_ForNow()); | |||
| mdns::Minimal::QueryBuilder builder(buffer.Retain()); | |||
There was a problem hiding this comment.
Hmm. It seems like we could make the builder take a const ref to PacketBufferHandle (and have its member be a const ref) and avoid the extra refcounting And here we could scope it so it goes out of scope before we do the BroadcastSend call...
There was a problem hiding this comment.
Ah, yes. I probably had TLV's chaining in mind when I converted this one. Fixed.
andy31415
approved these changes
Dec 7, 2020
bzbarsky-apple
approved these changes
Dec 7, 2020
|
@kpschoedel Merge conflicts? |
|
also #4102 has some conversions to PacketBufferHandle (not sure if the same, but if we could make them similar it may be easier to merge) |
rwalker-apple
approved these changes
Dec 7, 2020
jelderton
approved these changes
Dec 8, 2020
BroderickCarlin
approved these changes
Dec 9, 2020
mspang
approved these changes
Dec 10, 2020
kpschoedel
added a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Jan 8, 2021
…4094) * Convert mdns Builder classes to use PacketBufferHandle #### Problem Code should use `PacketBufferHandle` rather than `PacketBuffer` directly. #### Summary of Changes Convert mdns::Minimal::QueryBuilder and mdns::Minimal::ResponseBuilder to take and hold PacketBufferHandle. Part of issue project-chip#2707 - Figure out a way to express PacketBuffer ownership in the type system * Review: make QueryBuilder take const& * WIP * Revise to match ResponseBuilder in project-chip#4102 * Restyled by clang-format * remove PacketReporter.cpp change Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Code should use
PacketBufferHandlerather thanPacketBufferdirectly.
Summary of Changes
Convert mdns::Minimal::QueryBuilder and mdns::Minimal::ResponseBuilder
to take and hold PacketBufferHandle.
Part of issue #2707 - Figure out a way to express PacketBuffer ownership in the type system