Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple ember functions from wifi diagnostic cluster #37097

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Decouple ember functions from wifi diagnostic cluster #37097

wants to merge 1 commit into from
+42 −109

Conversation

yufengwangca
Copy link
Contributor

@yufengwangca yufengwangca commented Jan 17, 2025 •
edited
Loading

Decouple WiFi Network Diagnostic Cluster from ember and migrate to use CHI (CommandHandlerInterface) instead

Fix: #36892

Testing

Verified with manual pairing and CI

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@github-actions github-actions bot added the app label Jan 17, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

PR #37097: Size comparison from 61fe32f to 8fdecff

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 61fe32f 8fdecff change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1093164 1093202 38 0.0
RAM 103354 103370 16 0.0
bl702 lighting-app bl702+eth FLASH 651226 651226 0 0.0
RAM 25361 25361 0 0.0
bl702+wifi FLASH 829150 829188 38 0.0
RAM 14101 14101 0 0.0
bl706+mfd+rpc+littlefs FLASH 1056180 1056180 0 0.0
RAM 23957 23957 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 889204 889204 0 0.0
RAM 18632 18632 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 972164 972164 0 0.0
RAM 16480 16480 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838436 838420 -16 -0.0
RAM 123536 123552 16 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823784 823768 -16 -0.0
RAM 125416 125432 16 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771104 771104 0 0.0
RAM 113900 113900 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755300 755300 0 0.0
RAM 114100 114100 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538781 538781 0 0.0
RAM 205288 205288 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572629 572589 -40 -0.0
RAM 205424 205440 16 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679881 679833 -48 -0.0
RAM 78596 78612 16 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699733 699685 -48 -0.0
RAM 81236 81252 16 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699733 699685 -48 -0.0
RAM 81236 81252 16 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656669 656621 -48 -0.0
RAM 73664 73680 16 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616289 616241 -48 -0.0
RAM 71588 71604 16 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635925 635877 -48 -0.0
RAM 74132 74148 16 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635925 635877 -48 -0.0
RAM 74132 74148 16 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635753 635705 -48 -0.0
RAM 74588 74604 16 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655469 655421 -48 -0.0
RAM 77132 77148 16 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655469 655421 -48 -0.0
RAM 77132 77148 16 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 612301 612253 -48 -0.0
RAM 68684 68700 16 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 632161 632113 -48 -0.0
RAM 71316 71332 16 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 632161 632113 -48 -0.0
RAM 71316 71332 16 0.0
efr32 lock-app BRD4187C FLASH 935112 935080 -32 -0.0
RAM 160004 160004 0 0.0
BRD4338a FLASH 730804 730844 40 0.0
RAM 234844 234860 16 0.0
window-app BRD4187C FLASH 1030456 1030520 64 0.0
RAM 128112 128112 0 0.0
esp32 all-clusters-app c3devkit DRAM 95192 95208 16 0.0
FLASH 1538592 1538536 -56 -0.0
IRAM 82552 82552 0 0.0
m5stack DRAM 116172 116188 16 0.0
FLASH 1545810 1545790 -20 -0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2710271 2710271 0 0.0
RAM 133096 133096 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5976336 5976418 82 0.0
RAM 531880 531976 96 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5324354 5325382 1028 0.0
RAM 242992 243088 96 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4682582 4683642 1060 0.0
RAM 221744 221840 96 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 13045234 13045234 0 0.0
RAM 596634 596634 0 0.0
chip-tool-ipv6only arm64 unknown 21816 21816 0 0.0
FLASH 11125744 11125744 0 0.0
RAM 648168 648168 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11392209 11392209 0 0.0
RAM 596978 596978 0 0.0
fabric-bridge-app debug unknown 4728 4728 0 0.0
FLASH 4507632 4508660 1028 0.0
RAM 208880 208976 96 0.0
fabric-sync debug unknown 4968 4968 0 0.0
FLASH 5610437 5611461 1024 0.0
RAM 483656 483752 96 0.0
lighting-app debug+rpc+ui unknown 6136 6136 0 0.0
FLASH 5617905 5618001 96 0.0
RAM 232008 232104 96 0.0
lock-app debug unknown 5408 5408 0 0.0
FLASH 4731538 4731656 118 0.0
RAM 207976 208072 96 0.0
ota-provider-app debug unknown 4768 4768 0 0.0
FLASH 4361240 4361240 0 0.0
RAM 201696 201696 0 0.0
ota-requestor-app debug unknown 4720 4720 0 0.0
FLASH 4498914 4498914 0 0.0
RAM 206280 206280 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3006717 3006797 80 0.0
RAM 160736 160832 96 0.1
thermostat-no-ble arm64 unknown 9568 9568 0 0.0
FLASH 4102184 4102296 112 0.0
RAM 246224 246280 56 0.0
tv-app debug unknown 5736 5736 0 0.0
FLASH 5950597 5951653 1056 0.0
RAM 607088 607184 96 0.0
tv-casting-app debug unknown 5312 5312 0 0.0
FLASH 11273069 11274093 1024 0.0
RAM 711064 711192 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914768 914672 -96 -0.0
RAM 143172 143188 16 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890116 890020 -96 -0.0
RAM 141359 141375 16 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 849488 849636 148 0.0
RAM 142084 142100 16 0.0
nxp contact k32w0+release FLASH 584504 584504 0 0.0
RAM 70952 70952 0 0.0
mcxw71+release FLASH 600024 600024 0 0.0
RAM 63168 63168 0 0.0
light k32w0+release FLASH 611188 611188 0 0.0
RAM 70344 70344 0 0.0
k32w1+release FLASH 685736 685736 0 0.0
RAM 48760 48760 0 0.0
lock mcxw71+release FLASH 761800 761800 0 0.0
RAM 70796 70796 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1648060 1647980 -80 -0.0
RAM 211624 211640 16 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1554628 1554932 304 0.0
RAM 208440 208456 16 0.0
light cy8ckit_062s2_43012 FLASH 1470172 1470220 48 0.0
RAM 200408 200424 16 0.0
lock cy8ckit_062s2_43012 FLASH 1467884 1467948 64 0.0
RAM 224760 224776 16 0.0
qpg lighting-app qpg6105+debug FLASH 662552 662552 0 0.0
RAM 105296 105296 0 0.0
lock-app qpg6105+debug FLASH 620268 620268 0 0.0
RAM 99748 99748 0 0.0
stm32 light STM32WB5MM-DK FLASH 483240 483208 -32 -0.0
RAM 144752 144768 16 0.0
telink bridge-app tlsr9258a FLASH 682276 682422 146 0.0
RAM 91088 91104 16 0.0
contact-sensor-app tlsr9528a_retention FLASH 622566 622486 -80 -0.0
RAM 31488 31504 16 0.1
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 771344 771294 -50 -0.0
RAM 49348 49364 16 0.0
light-app-ota-shell-factory-data tl7218x FLASH 775948 775870 -78 -0.0
RAM 99652 99668 16 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 709794 709716 -78 -0.0
RAM 73384 73400 16 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 626894 626816 -78 -0.0
RAM 142020 142036 16 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 812958 812880 -78 -0.0
RAM 99564 99580 16 0.0
tizen all-clusters-app arm unknown 5132 5132 0 0.0
FLASH 1755280 1755368 88 0.0
RAM 93672 93720 48 0.1
chip-tool-ubsan arm unknown 11044 11044 0 0.0
FLASH 18216638 18216638 0 0.0
RAM 7958464 7958464 0 0.0

@yufengwangca yufengwangca changed the title Decouple ember functions from general diagnostic cluster Decouple ember functions from wifi diagnostic cluster Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
app review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Cluster Decoupling: wifi-diagnostic-cluster
1 participant
@yufengwangca