Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo time sync in Matter.framework if we discover the server's clock is way off. #37089

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Redo time sync in Matter.framework if we discover the server's clock is way off. #37089

wants to merge 1 commit into from
+73 −4

Conversation

bzbarsky-apple
Copy link
Contributor

If a server is powered down for a while and its clock loses sync, when it reboots we will re-subscribe to it. At that point we can detect whether its clock is off by too much and adjust it, if so.

Testing

Manual testing; doing anything with clocks in CI is hard.

@bzbarsky-apple
Redo time sync in Matter.framework if we discover the server's clock …
b14a815 
…is way off.

If a server is powered down for a while and its clock loses sync, when it
reboots we will re-subscribe to it.  At that point we can detect whether its
clock is off by too much and adjust it, if so.
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

PR #37089: Size comparison from e8196ff to b14a815

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section e8196ff b14a815 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1094048 1094048 0 0.0
RAM 103354 103354 0 0.0
bl702 lighting-app bl702+eth FLASH 652110 652110 0 0.0
RAM 25361 25361 0 0.0
bl702+wifi FLASH 830034 830034 0 0.0
RAM 14101 14101 0 0.0
bl706+mfd+rpc+littlefs FLASH 1057320 1057320 0 0.0
RAM 23957 23957 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 890344 890344 0 0.0
RAM 18632 18632 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 973304 973304 0 0.0
RAM 16480 16480 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 839628 839628 0 0.0
RAM 123536 123536 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825080 825080 0 0.0
RAM 125424 125424 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772072 772072 0 0.0
RAM 113900 113900 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756252 756252 0 0.0
RAM 114100 114100 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 539693 539693 0 0.0
RAM 205288 205288 0 0.0
lock CC3235SF_LAUNCHXL FLASH 573789 573789 0 0.0
RAM 205432 205432 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 681097 681097 0 0.0
RAM 78596 78596 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 700949 700949 0 0.0
RAM 81236 81236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 700949 700949 0 0.0
RAM 81236 81236 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 657885 657885 0 0.0
RAM 73664 73664 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 617633 617633 0 0.0
RAM 71588 71588 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 637269 637269 0 0.0
RAM 74132 74132 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 637269 637269 0 0.0
RAM 74132 74132 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 637081 637081 0 0.0
RAM 74596 74596 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 656789 656789 0 0.0
RAM 77140 77140 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 656789 656789 0 0.0
RAM 77140 77140 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 613829 613829 0 0.0
RAM 68684 68684 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 633681 633681 0 0.0
RAM 71316 71316 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 633681 633681 0 0.0
RAM 71316 71316 0 0.0
efr32 lock-app BRD4187C FLASH 936448 936448 0 0.0
RAM 160004 160004 0 0.0
BRD4338a FLASH 732212 732204 -8 -0.0
RAM 234844 234844 0 0.0
window-app BRD4187C FLASH 1031960 1031960 0 0.0
RAM 128112 128112 0 0.0
esp32 all-clusters-app c3devkit DRAM 95192 95192 0 0.0
FLASH 1541312 1541312 0 0.0
IRAM 82552 82552 0 0.0
m5stack DRAM 116172 116172 0 0.0
FLASH 1547798 1547798 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2714813 2714813 0 0.0
RAM 133096 133096 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5985354 5985354 0 0.0
RAM 531832 531832 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5331698 5331698 0 0.0
RAM 243008 243008 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4687652 4687652 0 0.0
RAM 221760 221760 0 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 13045170 13045170 0 0.0
RAM 596634 596634 0 0.0
chip-tool-ipv6only arm64 unknown 21816 21816 0 0.0
FLASH 11125584 11125584 0 0.0
RAM 648168 648168 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11392145 11392145 0 0.0
RAM 596978 596978 0 0.0
fabric-bridge-app debug unknown 4728 4728 0 0.0
FLASH 4511888 4511888 0 0.0
RAM 208880 208880 0 0.0
fabric-sync debug unknown 4968 4968 0 0.0
FLASH 5614693 5614693 0 0.0
RAM 483656 483656 0 0.0
lighting-app debug+rpc+ui unknown 6136 6136 0 0.0
FLASH 5622433 5622433 0 0.0
RAM 232008 232008 0 0.0
lock-app debug unknown 5408 5408 0 0.0
FLASH 4736048 4736048 0 0.0
RAM 208008 208008 0 0.0
ota-provider-app debug unknown 4768 4768 0 0.0
FLASH 4365018 4365018 0 0.0
RAM 201696 201696 0 0.0
ota-requestor-app debug unknown 4720 4720 0 0.0
FLASH 4502944 4502944 0 0.0
RAM 206280 206280 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3014861 3014861 0 0.0
RAM 160736 160736 0 0.0
thermostat-no-ble arm64 unknown 9552 9552 0 0.0
FLASH 4105624 4105624 0 0.0
RAM 246224 246224 0 0.0
tv-app debug unknown 5736 5736 0 0.0
FLASH 5956933 5956933 0 0.0
RAM 607088 607088 0 0.0
tv-casting-app debug unknown 5312 5312 0 0.0
FLASH 11277869 11277869 0 0.0
RAM 711064 711064 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917388 917388 0 0.0
RAM 143172 143172 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890880 890880 0 0.0
RAM 141359 141359 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 851516 851516 0 0.0
RAM 142084 142084 0 0.0
nxp contact k32w0+release FLASH 585464 585464 0 0.0
RAM 70952 70952 0 0.0
mcxw71+release FLASH 600984 600984 0 0.0
RAM 63168 63168 0 0.0
light k32w0+release FLASH 612148 612148 0 0.0
RAM 70344 70344 0 0.0
k32w1+release FLASH 686696 686696 0 0.0
RAM 48760 48760 0 0.0
lock mcxw71+release FLASH 762952 762952 0 0.0
RAM 70796 70796 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1650908 1650908 0 0.0
RAM 211624 211624 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1556916 1556916 0 0.0
RAM 208440 208440 0 0.0
light cy8ckit_062s2_43012 FLASH 1471596 1471596 0 0.0
RAM 200408 200408 0 0.0
lock cy8ckit_062s2_43012 FLASH 1469332 1469332 0 0.0
RAM 224760 224760 0 0.0
qpg lighting-app qpg6105+debug FLASH 663688 663688 0 0.0
RAM 105296 105296 0 0.0
lock-app qpg6105+debug FLASH 621500 621500 0 0.0
RAM 99748 99748 0 0.0
stm32 light STM32WB5MM-DK FLASH 484448 484448 0 0.0
RAM 144752 144752 0 0.0
telink bridge-app tlsr9258a FLASH 683134 683134 0 0.0
RAM 91088 91088 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 623392 623392 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 772234 772234 0 0.0
RAM 49348 49348 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 776838 776838 0 0.0
RAM 99652 99652 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 710774 710774 0 0.0
RAM 73384 73384 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 627776 627776 0 0.0
RAM 142020 142020 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813848 813848 0 0.0
RAM 99564 99564 0 0.0
tizen all-clusters-app arm unknown 5120 5120 0 0.0
FLASH 1761104 1761104 0 0.0
RAM 93672 93672 0 0.0
chip-tool-ubsan arm unknown 11044 11044 0 0.0
FLASH 18216310 18216310 0 0.0
RAM 7958272 7958272 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bzbarsky-apple