Add test steps 50-60 from the Thermostat test plan to the Thermostat … #37052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…YAML script - Remove Test_TC_TSTAT_4_1.yaml
|
Review changes with Changed Files
|
|
PR #37052: Size comparison from 5bd63d5 to eeba018 Full report (55 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
nivi-apple
force-pushed
the
fix_TSTAT_test_scripts
branch
from
eeba018 to
0ac98e8
Compare
|
PR #37052: Size comparison from 5bd63d5 to 0ac98e8 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37052: Size comparison from 5bd63d5 to bbbef87 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
KishokG
reviewed
Jan 15, 2025
| PICS: TSTAT.S.F08 && TSTAT.S.A0050 | ||
| command: "readAttribute" | ||
| attribute: "Presets" | ||
| response: |
There was a problem hiding this comment.
@nivi-apple As per testplan we need to add this check on the script: Verify that the list has no more than NumberOfPresets entries
cjandhyala
reviewed
Jan 16, 2025
| @@ -730,3 +730,97 @@ tests: | |||
| value: 0 | |||
| constraints: | |||
| type: enum8 | |||
|
|
|||
There was a problem hiding this comment.
why are steps not matching exactly with the test plan. If you see above steps, Step 11 from test plan is missing and coded as step 12, since then all steps in the script are not aligned with the test plan.
| @@ -730,3 +730,97 @@ tests: | |||
| value: 0 | |||
| constraints: | |||
| type: enum8 | |||
|
|
|||
| - label: "Step 52: TH reads the PresetTypes attribute from the DUT" | |||
| PICS: TSTAT.S.F08 && TSTAT.S.A0048 | |||
There was a problem hiding this comment.
Bcoz of most of the below attributes are mandatory when the feature is present, I don't think you need both the PICS here. Just have one PICS TSTAT.S.F08, that way anyone implementing that feature must implement these attributes. You can update the same in the test plan too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Test_TC_TSTAT_2_1.yaml script
Fixes: #37051
Testing
Run the test steps manually.