Creating friendly functions for establishing new controllers on existing or new fabrics #37009
+143
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is to help resolve task filed: project-chip/matter-test-scripts#465 - Created 2 friendly functions for establishing new controllers on new and existing fabrics
|
Review changes with Changed Files
|
github-actions
bot
added
tests
matter-1.4-te2-script-change
|
PR #37009: Size comparison from f25f635 to 89c27a6 Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jan 9, 2025
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Jan 9, 2025
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Jan 9, 2025
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
- Moved code from matter_testing support module to CertificateAuthority module's CertificateAuthorityManager class - Changed to using 1 single function for both creating controllers, thne if statement to determine if using a new or existing fabric - Created new standalone script to test functionality.
- Resolving linting errors
Changiing adminList[] value back to 0 for the moment.
andy31415
reviewed
Jan 16, 2025
| @@ -315,6 +315,21 @@ def NewCertificateAuthority(self, caIndex: Optional[int] = None, maximizeCertCha | |||
|
|
|||
| return ca | |||
|
|
|||
| def create_new_controller(self, vendorid: int = 0xFFF1, fabricId: int = 1, new_fabric: bool = True, CaList: int = 0, nodeid: int = 2): | |||
There was a problem hiding this comment.
CaList as a name does not match the others and seems to confuse git syntax coloring. Overall we have to pick a style as we seem to have:
- vendrid and nodeid are
lowercaseconcatenated - fabricId is
lowerCamelCase - new_fabric is
lower_snake_case - CaList is
UppserCamelCase
I like consistency. Let's use lower_camel_case for all argument names as I believe this is typical for python.
There was a problem hiding this comment.
That sounds good,
It is a bit interesting that the CaList arg name triggered the git syntax coloring in that way lol.
I will get this updated to using lower_camel_case for the argument names.
andy31415
approved these changes
Jan 16, 2025
- Updated to change arg names to using lower_snake_case for create_new_controller function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Added standalone test script "src/python_testing/TC_CreateNewController.py" to validate